On Tue, Jun 21, 2011 at 03:32:58PM +0200, Marc-André Lureau wrote:
> > It's the only place where mute is an int, why not make it a uint8_t as
> > everywhere else?
> > Another issue I have with mute is that I assume it's a boolean, however
> > there is no place at all where it's made obvious, it cou
Hi
On Tue, Jun 21, 2011 at 3:22 PM, Christophe Fergeau wrote:
> Hi,
>
> I finally read the patch in full ;) You'll find a few minor comments
> inline.
>
> On Mon, Jun 20, 2011 at 11:40:01PM +0200, Marc-André Lureau wrote:
>> @@ -141,14 +145,22 @@ struct SndWorker {
>> int active;
>> };
>>
>
Hi,
I finally read the patch in full ;) You'll find a few minor comments
inline.
On Mon, Jun 20, 2011 at 11:40:01PM +0200, Marc-André Lureau wrote:
> @@ -141,14 +145,22 @@ struct SndWorker {
> int active;
> };
>
> +typedef struct SpiceVolumeState {
> +uint8_t volume_nchannels;
> +
On Tue, Jun 21, 2011 at 02:24:23PM +0200, Marc-André Lureau wrote:
> What do you mean by "volume format"? It's a an uint16_t, for which 0
> means 0% = MUTE, and 65535 or 100% = NORMAL.
some kind of enum for when we add support for volume in dB, ie
AudioVolume {
enum AudioVolumeFormat format;
On Tue, Jun 21, 2011 at 2:19 PM, Christophe Fergeau wrote:
> On Tue, Jun 21, 2011 at 12:58:23PM +0200, Marc-André Lureau wrote:
>> So we can simply change the message "volume" in % to "volume_db" in
>> dB, if both parts say they have the capability to handle volume in dB.
>> That's roughly what I
On Tue, Jun 21, 2011 at 12:58:23PM +0200, Marc-André Lureau wrote:
> So we can simply change the message "volume" in % to "volume_db" in
> dB, if both parts say they have the capability to handle volume in dB.
> That's roughly what I had in mind.
Ok, so we'll switch from "arbitrary scale" to "dB"
Hi,
On Tue, Jun 21, 2011 at 10:48 AM, Christophe Fergeau
wrote:
> On Tue, Jun 21, 2011 at 12:05:56AM +0200, Marc-André Lureau wrote:
>> So, the answer in short is that I don't know, but I know it can be
>> addressed later, for example when we use dB, which is way better for
>> emulated hw. But th
On Tue, Jun 21, 2011 at 12:05:56AM +0200, Marc-André Lureau wrote:
> So, the answer in short is that I don't know, but I know it can be
> addressed later, for example when we use dB, which is way better for
> emulated hw. But that needs even more work, I wanted the basics first.
The thing is, once
hi
On Mon, Jun 20, 2011 at 11:53 PM, Christophe Fergeau
wrote:
> Hi,
>
> On Mon, Jun 20, 2011 at 11:40:01PM +0200, Marc-André Lureau wrote:
>> These messages allow the guest to send the audio device volume to the
>> client. It uses an arbitrary scale of 16bits, which works good enough
>> for now.
Hi,
On Mon, Jun 20, 2011 at 11:40:01PM +0200, Marc-André Lureau wrote:
> These messages allow the guest to send the audio device volume to the
> client. It uses an arbitrary scale of 16bits, which works good enough
> for now.
This adds this arbitrary scale to the protocol, is this scale "good eno
These messages allow the guest to send the audio device volume to the
client. It uses an arbitrary scale of 16bits, which works good enough
for now.
Save VolumeState in {Playback,Record}State, so that we can send the
current volume on channel connection.
Note about future improvements:
- add exac
11 matches
Mail list logo
