Re: [Spice-devel] [PATCH spice 1/2] Use spice_strdup() to avoid crashing on NULL

2012-03-21 Thread Alon Levy
On Wed, Mar 21, 2012 at 12:43:00PM +0200, Alon Levy wrote: > On Tue, Mar 20, 2012 at 08:30:50PM +0100, Marc-André Lureau wrote: > > qemu can call spice_server_set_name(s, NULL) when the name is not > > given. Let's not crash in this case > > /me wonders how he never saw the crash, he doesn't pass

Re: [Spice-devel] [PATCH spice 1/2] Use spice_strdup() to avoid crashing on NULL

2012-03-21 Thread Alon Levy
On Tue, Mar 20, 2012 at 08:30:50PM +0100, Marc-André Lureau wrote: > qemu can call spice_server_set_name(s, NULL) when the name is not > given. Let's not crash in this case /me wonders how he never saw the crash, he doesn't pass -name Also, this patch just does s/strdup/spice_strdup/ or am I miss

Re: [Spice-devel] [PATCH spice 1/2] Use spice_strdup() to avoid crashing on NULL

2012-03-20 Thread Hans de Goede
Ack series. On 03/20/2012 08:30 PM, Marc-André Lureau wrote: qemu can call spice_server_set_name(s, NULL) when the name is not given. Let's not crash in this case --- server/main_channel.c |4 ++-- server/red_tunnel_worker.c |4 ++-- server/reds.c | 12 ++-

[Spice-devel] [PATCH spice 1/2] Use spice_strdup() to avoid crashing on NULL

2012-03-20 Thread Marc-André Lureau
qemu can call spice_server_set_name(s, NULL) when the name is not given. Let's not crash in this case --- server/main_channel.c |4 ++-- server/red_tunnel_worker.c |4 ++-- server/reds.c | 12 ++-- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a