Re: [Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

2016-10-27 Thread Jonathon Jongsma
Aside from the comment about potentially splitting patch 11/12, all of the fixups look good to me. However, I seem to be missing patches 5/12, 9/12, and 12/12. Did they get sent? Jonathon On Mon, 2016-10-24 at 09:40 +0100, Frediano Ziglio wrote: > Some different fixup with updates and small cha

Re: [Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

2016-10-25 Thread Jonathon Jongsma
On Tue, 2016-10-25 at 11:08 -0400, Frediano Ziglio wrote: > > > > > > On Tue, 2016-10-25 at 04:40 -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > > > > > > Aside from the comment about potentially splitting patch 11/12, > > > > all > > > > of > > > > the fixups look good to me. > >

Re: [Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

2016-10-25 Thread Frediano Ziglio
> > On Tue, 2016-10-25 at 04:40 -0400, Frediano Ziglio wrote: > > > > > > > > > Aside from the comment about potentially splitting patch 11/12, all > > > of > > > the fixups look good to me. > > > > > > > Yes, possibly make more sense with the comment in 12/12 although > > they also remove the

Re: [Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

2016-10-25 Thread Jonathon Jongsma
On Tue, 2016-10-25 at 04:40 -0400, Frediano Ziglio wrote: > > > > > > Aside from the comment about potentially splitting patch 11/12, all > > of > > the fixups look good to me. > > > > Yes, possibly make more sense with the comment in 12/12 although > they also remove the warning replacing with

Re: [Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

2016-10-25 Thread Frediano Ziglio
> > Aside from the comment about potentially splitting patch 11/12, all of > the fixups look good to me. > Yes, possibly make more sense with the comment in 12/12 although they also remove the warning replacing with the old check during construction. However as they'll be squashed in the same pa

[Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

2016-10-24 Thread Frediano Ziglio
Some different fixup with updates and small changes. Frediano Ziglio (11): fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel hierarchy to GObject fixup! Convert RedChannel