Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-21 Thread Jonathon Jongsma
On Thu, 2017-09-21 at 08:58 -0400, Frediano Ziglio wrote: > I think this is a matter of style and as such just different > opinions. > > Considering the current mixed style I would proposed a poll. > > I obviously vote for moving to GLib functions directly. This is my vote as well (which is mayb

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-21 Thread Christophe de Dinechin
> On 21 Sep 2017, at 14:58, Frediano Ziglio wrote: > >>> >>> On 20 Sep 2017, at 18:27, Christophe Fergeau wrote: >>> >>> On Wed, Sep 20, 2017 at 06:15:49PM +0200, Christophe de Dinechin wrote: > On 20 Sep 2017, at 17:51, Christophe Fergeau wrote: > > On Wed, Sep 20,

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-21 Thread Christophe Fergeau
On Thu, Sep 21, 2017 at 08:58:04AM -0400, Frediano Ziglio wrote: > I obviously vote for moving to GLib functions directly. Regarding the amount of changes this means, and potential extra-rebasing work, one possible way of integrating these changes would be to only switch to glib a function or a fi

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-21 Thread Frediano Ziglio
> > > On 20 Sep 2017, at 18:27, Christophe Fergeau wrote: > > > > On Wed, Sep 20, 2017 at 06:15:49PM +0200, Christophe de Dinechin wrote: > >> > >> > >>> On 20 Sep 2017, at 17:51, Christophe Fergeau wrote: > >>> > >>> On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: >

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-21 Thread Christophe de Dinechin
> On 20 Sep 2017, at 18:27, Christophe Fergeau wrote: > > On Wed, Sep 20, 2017 at 06:15:49PM +0200, Christophe de Dinechin wrote: >> >> >>> On 20 Sep 2017, at 17:51, Christophe Fergeau wrote: >>> >>> On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: > O

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe Fergeau
On Wed, Sep 20, 2017 at 06:15:49PM +0200, Christophe de Dinechin wrote: > > > > On 20 Sep 2017, at 17:51, Christophe Fergeau wrote: > > > > On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: > >> > >> > >>> On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: > >>> > >>>

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 17:51, Christophe Fergeau wrote: > > On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: >> >> >>> On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: >>> >>> On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > >> The b

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe Fergeau
On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: > > > > On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: > > > > On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > >>> > The benefit of doing it that way (in addition to requiring less sourc

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Frediano Ziglio
> > On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > > > > > >> The benefit of doing it that way (in addition to requiring less source > > >> code > > >> changes and making following rebases or merge much easier) is that it > > >> leaves > > >> the option to instrument sp

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: > > On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: >>> The benefit of doing it that way (in addition to requiring less source code changes and making following rebases or merge much easier) is that it >>>

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe Fergeau
On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > > > >> The benefit of doing it that way (in addition to requiring less source code > >> changes and making following rebases or merge much easier) is that it > >> leaves > >> the option to instrument spice allocations speci

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Matthew Francis
On 20 September 2017 at 20:54, Christophe de Dinechin wrote: > >> On 20 Sep 2017, at 11:53, Frediano Ziglio wrote: >> There are many tools to instruments memory allocations and is not hard >> to write one on your own. For instance knowing that objects file takes >> precedence over libraries you

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 11:53, Frediano Ziglio wrote: > >>> >>> On 20 Sep 2017, at 09:50, Frediano Ziglio wrote: >>> >>> Reduce the usage of spice_new*/spice_malloc* allocations. >>> They were designed in a similar way to GLib ones. >>> Now that we use GLib make sense to remove them. >>> Howeve

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Frediano Ziglio
> > > On 20 Sep 2017, at 09:50, Frediano Ziglio wrote: > > > > Reduce the usage of spice_new*/spice_malloc* allocations. > > They were designed in a similar way to GLib ones. > > Now that we use GLib make sense to remove them. > > However the versions we support for GLib can use different memory

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 09:50, Frediano Ziglio wrote: > > Reduce the usage of spice_new*/spice_malloc* allocations. > They were designed in a similar way to GLib ones. > Now that we use GLib make sense to remove them. > However the versions we support for GLib can use different memory > allocators

[Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Frediano Ziglio
Reduce the usage of spice_new*/spice_malloc* allocations. They were designed in a similar way to GLib ones. Now that we use GLib make sense to remove them. However the versions we support for GLib can use different memory allocators so we have to match g_free with GLib allocations and spice_* ones