Re: [Spice-devel] [PATCH spice-server 7/9] reds: Fix wrong assert

2017-12-05 Thread Uri Lublin
On 12/05/2017 10:41 AM, Frediano Ziglio wrote: RedVDIReadBuf::data is a static allocated buffer so checking for NULL on it is useless. It would be NULL only if RedVDIReadBuf pointer would be the opposite, in value, of the offset of data field into it. Signed-off-by: Frediano Ziglio Acked-by:

[Spice-devel] [PATCH spice-server 7/9] reds: Fix wrong assert

2017-12-05 Thread Frediano Ziglio
RedVDIReadBuf::data is a static allocated buffer so checking for NULL on it is useless. It would be NULL only if RedVDIReadBuf pointer would be the opposite, in value, of the offset of data field into it. Signed-off-by: Frediano Ziglio --- Maybe this check should just be removed? --- server/reds