Re: [Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

2017-02-28 Thread Christophe Fergeau
On Tue, Feb 28, 2017 at 09:34:48AM -0500, Frediano Ziglio wrote: > Just to be clear: > > "reds: Check that we do not free the wrong agent device > > Do not assume the device passed is the one currently working > but check for it and refuse to free the current one avoiding > possible double free o

Re: [Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

2017-02-28 Thread Frediano Ziglio
Just to be clear: "reds: Check that we do not free the wrong agent device Do not assume the device passed is the one currently working but check for it and refuse to free the current one avoiding possible double free of the device." (was not clear to me if you meant the subject or message) Fred

Re: [Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

2017-02-28 Thread Christophe Fergeau
I think I'd adjust the shortlog a little bit "Check that we do not free ...", as I initially thought this was fixing an actual bug rather than being a robustness improvement. Hopefully we don't hit this situation, as this would be fairly bad ;) Acked-by: Christophe Fergeau Christophe On Tue,

[Spice-devel] [PATCH spice-server] reds: Do not free wrong agent device

2017-02-28 Thread Frediano Ziglio
Do not assume the device passed is the one currently working but check for it and refuse to free the current one avoiding possible double free of the device. Signed-off-by: Frediano Ziglio --- server/reds.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/reds.c b