Re: [Spice-devel] [PATCH spice-server] red-replay-qxl: Fix replay on 32 bit systems

2019-08-11 Thread Snir Sheriber
Hi, Acked-by: Snir Sheriber nice catch Snir. On 7/23/19 11:22 AM, Frediano Ziglio wrote: On 32 systems pointers are 32 bit while QXLPHYSICAL is always 64 bit. Using pointer -> intptr_t -> QXLPHYSICAL conversion cause pointers to have higher 32 bit set to 1 if the address is >= 0x8000. Th

Re: [Spice-devel] [PATCH spice-server] red-replay-qxl: Fix replay on 32 bit systems

2019-08-09 Thread Frediano Ziglio
ping > > ping > > > > > On 32 systems pointers are 32 bit while QXLPHYSICAL is always > > 64 bit. > > Using pointer -> intptr_t -> QXLPHYSICAL conversion cause pointers > > to have higher 32 bit set to 1 if the address is >= 0x8000. > > This is possible depending on address space. > > The Q

Re: [Spice-devel] [PATCH spice-server] red-replay-qxl: Fix replay on 32 bit systems

2019-08-05 Thread Frediano Ziglio
ping > > On 32 systems pointers are 32 bit while QXLPHYSICAL is always > 64 bit. > Using pointer -> intptr_t -> QXLPHYSICAL conversion cause pointers > to have higher 32 bit set to 1 if the address is >= 0x8000. > This is possible depending on address space. > The QXLPHYSICAL is split in 3 se

[Spice-devel] [PATCH spice-server] red-replay-qxl: Fix replay on 32 bit systems

2019-07-23 Thread Frediano Ziglio
On 32 systems pointers are 32 bit while QXLPHYSICAL is always 64 bit. Using pointer -> intptr_t -> QXLPHYSICAL conversion cause pointers to have higher 32 bit set to 1 if the address is >= 0x8000. This is possible depending on address space. The QXLPHYSICAL is split in 3 sections: - slot ID; -