Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-20 Thread Yaniv Kaul
Latest Spice dissector in Wireshark trunk[1] has been enhanced to support these two new main channel messages. (It was a bit surprising to find out the UUID is sent as big endian, while most of the protocol is little endian) Y. [1] http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/pack

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-04 Thread Marc-André Lureau
On Sun, Mar 4, 2012 at 10:54 AM, Yaniv Kaul wrote: > A single capability 'I-can-receive-name-uuid-or-both' should be enough, no? I thought of this too. But couldn't come up with a valid name and reason (we are talking about saving a bit sent once..). I thought about CAP_IDENTIFY, I guess it would

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-04 Thread Yaniv Kaul
On 03/02/2012 03:15 PM, Marc-André Lureau wrote: On Fri, Mar 2, 2012 at 2:10 PM, Christophe Fergeau wrote: Do we really need 2 separate messages for this? You don't necessarily have the 2 value available, you may have none, one or the other, or both. Do you really need two capabilities, thou

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-03 Thread Marc-André Lureau
Christophe, are you okay with the changes then? (I also would like to have a more generic "string" -> "value" dictionnary support for this kind of data, but the marshaller/demarshaller/proto doesn't know how to handle that, and that seems to be really less trivial than the proposed addition) On F

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-02 Thread Hans de Goede
Looks good, ack. Regards, Hans On 03/02/2012 01:46 PM, Marc-André Lureau wrote: This allows the client to identify a Spice server. This can be useful to associate data/configuration with this particular server. The corresponding main channel messages are: message { uint8 uuid[1

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-02 Thread Marc-André Lureau
On Fri, Mar 2, 2012 at 2:10 PM, Christophe Fergeau wrote: > Do we really need 2 separate messages for this? You don't necessarily have the 2 value available, you may have none, one or the other, or both. If we want to have a single message, we would have to use a boolean "is set" or an invalid v

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-02 Thread Christophe Fergeau
On Fri, Mar 02, 2012 at 01:46:58PM +0100, Marc-André Lureau wrote: > This allows the client to identify a Spice server. This can be useful > to associate data/configuration with this particular server. > > The corresponding main channel messages are: > > message { > uint8 uuid[16]; >

[Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-02 Thread Marc-André Lureau
This allows the client to identify a Spice server. This can be useful to associate data/configuration with this particular server. The corresponding main channel messages are: message { uint8 uuid[16]; } uuid; message { uint32 name_len; uint8 name[name_len]; /