Re: [Spice-devel] [PATCH spice-gtk v2 19/19] session: disconnect in idle

2014-11-19 Thread Christophe Fergeau
Hey, On Tue, Nov 18, 2014 at 04:41:12PM +0100, Marc-André Lureau wrote: > On Tue, Nov 18, 2014 at 4:26 PM, Christophe Fergeau > wrote: > > Well, no, in order to keep existing code to work, this _idle workaround > > was needed, then while I was not even to trying to test these changes, I > > hit

Re: [Spice-devel] [PATCH spice-gtk v2 19/19] session: disconnect in idle

2014-11-18 Thread Marc-André Lureau
On Tue, Nov 18, 2014 at 4:26 PM, Christophe Fergeau wrote: > Well, no, in order to keep existing code to work, this _idle workaround > was needed, then while I was not even to trying to test these changes, I > hit an issue introduced by these patches, I definitely expect a few more > to be lurking

Re: [Spice-devel] [PATCH spice-gtk v2 19/19] session: disconnect in idle

2014-11-18 Thread Christophe Fergeau
On Tue, Nov 18, 2014 at 04:13:09PM +0100, Marc-André Lureau wrote: > On Tue, Nov 18, 2014 at 4:02 PM, Christophe Fergeau > wrote: > > On Fri, Nov 14, 2014 at 12:32:42AM +0100, Marc-André Lureau wrote: > >> This is a workaround for existing clients such as virt-viewer that do > >> not hold a refer

Re: [Spice-devel] [PATCH spice-gtk v2 19/19] session: disconnect in idle

2014-11-18 Thread Marc-André Lureau
On Tue, Nov 18, 2014 at 4:02 PM, Christophe Fergeau wrote: > On Fri, Nov 14, 2014 at 12:32:42AM +0100, Marc-André Lureau wrote: >> This is a workaround for existing clients such as virt-viewer that do >> not hold a reference to their sessions when calling >> spice_session_disconnect() and crash no

Re: [Spice-devel] [PATCH spice-gtk v2 19/19] session: disconnect in idle

2014-11-18 Thread Christophe Fergeau
On Fri, Nov 14, 2014 at 12:32:42AM +0100, Marc-André Lureau wrote: > This is a workaround for existing clients such as virt-viewer that do > not hold a reference to their sessions when calling > spice_session_disconnect() and crash now that channels are removed from > session during the call. They

[Spice-devel] [PATCH spice-gtk v2 19/19] session: disconnect in idle

2014-11-13 Thread Marc-André Lureau
This is a workaround for existing clients such as virt-viewer that do not hold a reference to their sessions when calling spice_session_disconnect() and crash now that channels are removed from session during the call. They expect disconnection events to be deferred instead, let's defer actual disc