Re: [Spice-devel] [PATCH spice-gtk v2] main: Send monitor config only when it changes

2015-10-27 Thread Pavel Grunt
On Mon, 2015-10-26 at 15:03 -0500, Jonathon Jongsma wrote: > While I fully support the effort to reduce unnecessary monitor config > messages, I have one potential concern about this patch. This patch > compares the current display configuration to the last sent > configuration. However, it's theor

Re: [Spice-devel] [PATCH spice-gtk v2] main: Send monitor config only when it changes

2015-10-26 Thread Jonathon Jongsma
While I fully support the effort to reduce unnecessary monitor config messages, I have one potential concern about this patch. This patch compares the current display configuration to the last sent configuration. However, it's theoretically possible that the last sent configuration may not have bee

[Spice-devel] [PATCH spice-gtk v2] main: Send monitor config only when it changes

2015-10-26 Thread Pavel Grunt
When the guest recieves the monitor configuration message, it replies (through spice-server) by destroying the primary surface, which makes the SpiceDisplay disabled if its "resize-guest" property is used. This change of the display state (disabled/enabled) leads to sending a new monitor config mes