Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 04:37 PM, Marc-André Lureau wrote: On Wed, Nov 23, 2011 at 4:15 PM, Hans de Goede wrote: Ok, at least change the helper to use spice_session_get_read_only(priv->session), rather then g_object_get please :) I need to make it public then, but that's okay (spice-gtk in general

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Marc-André Lureau
On Wed, Nov 23, 2011 at 4:15 PM, Hans de Goede wrote: > Ok, at least change the helper to use > spice_session_get_read_only(priv->session), rather then g_object_get > please :) I need to make it public then, but that's okay (spice-gtk in general doesn't provide direct setter/getter). -- Marc-An

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 03:49 PM, Marc-André Lureau wrote: On Wed, Nov 23, 2011 at 3:38 PM, Hans de Goede wrote: Why introduce a separate function for this, why not simply call spice_session_get_read_only(priv->session) in the places where you now call read_only(self) ? it was just a small local h

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Marc-André Lureau
On Wed, Nov 23, 2011 at 3:38 PM, Hans de Goede wrote: > Why introduce a separate function for this, why not simply call > spice_session_get_read_only(priv->session) in the places where you now call > read_only(self) ? it was just a small local helper, could be turned into a macro perhaps, but I a

Re: [Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Hans de Goede
Hi, See my comments below. On 11/23/2011 01:23 PM, Marc-André Lureau wrote: It is useful to have a way to prevent sending commands in read-only sessions (think of multi-client) No clipboard sharing allowed in this case in gtk-session. --- gtk/spice-gtk-session-priv.h |1 + gtk/spice-gtk

[Spice-devel] [PATCH spice-gtk 6/8] RFC: Add read-only property on sessions

2011-11-23 Thread Marc-André Lureau
It is useful to have a way to prevent sending commands in read-only sessions (think of multi-client) No clipboard sharing allowed in this case in gtk-session. --- gtk/spice-gtk-session-priv.h |1 + gtk/spice-gtk-session.c | 23 +++ gtk/spice-session-priv.h |