Re: [Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 04:43 PM, Marc-André Lureau wrote: --- gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 80 -- gtk/spicy.c |6 +++ 3 files changed, 76 insertions(+), 11 deletions(-) Hmm, although the patch should

[Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 80 -- gtk/spicy.c |6 +++ 3 files changed, 76 insertions(+), 11 deletions(-) diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h index a86168d..bd5eec6 100644

Re: [Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Marc-André Lureau
Hi On Wed, Nov 23, 2011 at 3:24 PM, Hans de Goede wrote: > Since spice_g_signal_connect_object was moved to spice-util.h, this > chunk seems unnecessary (or the include should be spice-util.h not > spice-util-priv.h). correct, I don't need it anymore (leftover from earlier approach) > This chan

Re: [Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Hans de Goede
Hi, Some small remarks below, also I'm afraid that this conflicts with my "Release our keyboard grab when we're going to invoke the usb acl helper" patch, which I just pushed. I should have pushed it sooner, but I was waiting to get my additional 3 patches in shape and push them all in one go, so

[Spice-devel] [PATCH spice-gtk 5/8] Add disable-inputs on Spice widget

2011-11-23 Thread Marc-André Lureau
--- gtk/spice-widget-priv.h |1 + gtk/spice-widget.c | 111 +++--- gtk/spicy.c |6 +++ 3 files changed, 91 insertions(+), 27 deletions(-) diff --git a/gtk/spice-widget-priv.h b/gtk/spice-widget-priv.h index a5791a4..5065f7c 100644