Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Marc-André Lureau
You are right guys, and I keep getting it wrong.. Though emitting 2 times doesn't hurt ;) -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Christophe Fergeau
On Wed, Nov 23, 2011 at 03:17:46PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Nov 23, 2011 at 3:13 PM, Hans de Goede wrote: > > Hmm, I don't think this is necessary: > > 1) AFAIK gobject will do the notify itself after calling the property > > setting, > > No it doesn't, you have to do it

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 03:17 PM, Marc-André Lureau wrote: Hi On Wed, Nov 23, 2011 at 3:13 PM, Hans de Goede wrote: Hmm, I don't think this is necessary: 1) AFAIK gobject will do the notify itself after calling the property setting, No it doesn't, you have to do it yourself Are you sure? Becau

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Marc-André Lureau
Hi On Wed, Nov 23, 2011 at 3:13 PM, Hans de Goede wrote: > Hmm, I don't think this is necessary: > 1) AFAIK gobject will do the notify itself after calling the property > setting, No it doesn't, you have to do it yourself > 2) auto-usbredir is a new property and doesn't have any compat needs.

Re: [Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Hans de Goede
Hi, On 11/23/2011 01:23 PM, Marc-André Lureau wrote: So that compatibility code with deprecated properties work --- gtk/spice-gtk-session.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c index 116eead..c181c7e 100644

[Spice-devel] [PATCH spice-gtk 4/8] Notify when property changed

2011-11-23 Thread Marc-André Lureau
So that compatibility code with deprecated properties work --- gtk/spice-gtk-session.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c index 116eead..c181c7e 100644 --- a/gtk/spice-gtk-session.c +++ b/gtk/spice-gtk-session