Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-24 Thread Hans de Goede
Hi, On 06/24/2012 02:07 AM, Marc-André Lureau wrote: Hi On Sun, Jun 24, 2012 at 1:39 AM, Hans de Goede wrote: it can be simplified, resulting in simpler API and less code. No it cannot, using a hidden window for this is just plain wrong! One is supposed to use real toplevel windows with the

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-23 Thread Marc-André Lureau
Hi On Sun, Jun 24, 2012 at 1:39 AM, Hans de Goede wrote: >> it can be simplified, resulting in simpler API and less code. > > No it cannot, using a hidden window for this is just plain wrong! One is > supposed to use real toplevel windows with the inhibit API. > Well, in fact that toplevel_xid i

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-23 Thread Hans de Goede
Hi, On 06/23/2012 02:46 PM, Marc-André Lureau wrote: On Sat, Jun 23, 2012 at 9:05 AM, Hans de Goede wrote: Passing, what for all intends and purposes is a *fake* toplevel window id, is just gaming the system, this is not how the inhibit API is supposed to be used! The whole toplevel id is ther

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-23 Thread Marc-André Lureau
On Sat, Jun 23, 2012 at 9:05 AM, Hans de Goede wrote: > Passing, what for all intends and purposes is a *fake* toplevel window id, > is just gaming the system, this is not how the inhibit API is supposed to > be used! The whole toplevel id is there to avoid inhibits sticking around > when they sho

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-23 Thread Hans de Goede
Hi, On 06/22/2012 05:41 PM, Marc-André Lureau wrote: Just because many people use hash-tables for something does not make them the right choice, I looked at using hash-tables first, before I choose to use GData and I found GData to be a better match. Right, but if nobody does something this

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-22 Thread Marc-André Lureau
- Mensaje original - > Hi, > > On 06/22/2012 02:37 PM, Marc-André Lureau wrote: > > > >> The problem then becomes defining "nothing is done there", what if > >> we > >> are > >> compiled with dbus but not running under a supported desktop > >> environment? > >> > >> I guess I could ad

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-22 Thread Hans de Goede
Hi, On 06/22/2012 02:37 PM, Marc-André Lureau wrote: The problem then becomes defining "nothing is done there", what if we are compiled with dbus but not running under a supported desktop environment? I guess I could add a warning to spice_desktop_integration_init when we are missing desktop i

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-22 Thread Marc-André Lureau
Hi - Mensaje original - > > It would be more reliable to have a --with-desktop= and > > checking all the needed dependencies. > > That is not going to work, as once we support multiple desktops we > will want to > compile in support for more then one. So that the same binary can run > und

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-22 Thread Hans de Goede
Hi, Thanks for the comments. On 06/22/2012 11:06 AM, Marc-André Lureau wrote: Hi On Thu, Jun 21, 2012 at 10:09 PM, Hans de Goede wrote: + +AC_ARG_ENABLE([dbus], + AS_HELP_STRING([--enable-dbus=@<:@auto/yes/no@:>@], + [Enable dbus support for desktop integration (disabling au

Re: [Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-22 Thread Marc-André Lureau
Hi On Thu, Jun 21, 2012 at 10:09 PM, Hans de Goede wrote: > + > +AC_ARG_ENABLE([dbus], > +  AS_HELP_STRING([--enable-dbus=@<:@auto/yes/no@:>@], > +                 [Enable dbus support for desktop integration (disabling > automount) @<:@default=auto@:>@]), > +  [], > +  [enable_dbus="auto"]) It

[Spice-devel] [PATCH spice-gtk 2/4] Add a desktop-integration helper class

2012-06-21 Thread Hans de Goede
We need to integrate closely with the desktop environment of the user in several cases. Some examples are disabling auto-mounting when auto-usbredir is active (rhbz#812972), and disabling the screensaver when fullscreen (fdo#34793). Unfortuntely these kinds of things require desktop environment sp