Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

2014-11-14 Thread Christophe Fergeau
On Thu, Nov 13, 2014 at 05:18:51PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Nov 13, 2014 at 10:10 AM, Christophe Fergeau > wrote: > > > At first, I thought you meant that this function was no longer available > > at all, causing an ABI break. After reading the full patch, it seems you >

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

2014-11-13 Thread Marc-André Lureau
Hi On Thu, Nov 13, 2014 at 10:10 AM, Christophe Fergeau wrote: > At first, I thought you meant that this function was no longer available > at all, causing an ABI break. After reading the full patch, it seems you > mean this function has no non-deprecated replacement. Indicating whether > this i

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

2014-11-13 Thread Christophe Fergeau
Hey, I've seen your comment saying that this patch is not working as expected, however I had a comment related to the API doc, see below. On Sun, Nov 09, 2014 at 10:00:39PM +0100, Marc-André Lureau wrote: > This function is somewhat useless, and dangerous since it is > calling g_object_unref() on

Re: [Spice-devel] [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

2014-11-10 Thread Marc-André Lureau
this patch isn't working, I am fixing it On Sun, Nov 9, 2014 at 10:00 PM, Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > This function is somewhat useless, and dangerous since it is > calling g_object_unref() on your back (although this is mention in the > doc, I consider this a bad pr

[Spice-devel] [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

2014-11-09 Thread Marc-André Lureau
This function is somewhat useless, and dangerous since it is calling g_object_unref() on your back (although this is mention in the doc, I consider this a bad practice). --- gtk/spice-channel.c | 3 ++- gtk/spice-channel.h | 3 ++- gtk/spice-session.c | 8 3 files changed, 8 insertions(+)