Re: [Spice-devel] [PATCH spice-gtk 14/15] Remove some large stack allocations

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 02:56:07PM +0100, Hans de Goede wrote: > Hi, > > On 03/13/2012 02:40 PM, Daniel P. Berrange wrote: > >From: "Daniel P. Berrange" > > > >A few functions have very large arrays declared on the stack. > >Replace these with heap allocations, to reduce risk of stack > >overflows

Re: [Spice-devel] [PATCH spice-gtk 14/15] Remove some large stack allocations

2012-03-13 Thread Hans de Goede
Hi, Please see my comments on the original version. Regards, Hans On 03/13/2012 02:51 PM, Daniel P. Berrange wrote: On Tue, Mar 13, 2012 at 01:40:12PM +, Daniel P. Berrange wrote: From: "Daniel P. Berrange" A few functions have very large arrays declared on the stack. Replace these wit

Re: [Spice-devel] [PATCH spice-gtk 14/15] Remove some large stack allocations

2012-03-13 Thread Hans de Goede
Hi, On 03/13/2012 02:40 PM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" A few functions have very large arrays declared on the stack. Replace these with heap allocations, to reduce risk of stack overflows in deep callpaths --- gtk/channel-playback.c |6 -- gtk/spice-channel.

Re: [Spice-devel] [PATCH spice-gtk 14/15] Remove some large stack allocations

2012-03-13 Thread Daniel P. Berrange
On Tue, Mar 13, 2012 at 01:40:12PM +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > A few functions have very large arrays declared on the stack. > Replace these with heap allocations, to reduce risk of stack > overflows in deep callpaths > --- > gtk/channel-playback.c |6 ++

[Spice-devel] [PATCH spice-gtk 14/15] Remove some large stack allocations

2012-03-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" A few functions have very large arrays declared on the stack. Replace these with heap allocations, to reduce risk of stack overflows in deep callpaths --- gtk/channel-playback.c |6 -- gtk/spice-channel.c| 16 2 files changed, 16 insertio