ACK
- Original Message -
> From: "Marc-André Lureau"
> To: "Jonathon Jongsma"
> Cc: "spice-devel"
> Sent: Monday, April 28, 2014 12:40:20 PM
> Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device
> ref/unref
&
t; > To: "Jonathon Jongsma"
>> > Cc: "Uri Lublin" , "Marc-André Lureau" <
>> mlur...@redhat.com>, spice-de...@freedesktop.org
>> > Sent: Monday, April 28, 2014 11:54:03 AM
>> > Subject: Re: [Spice-devel] [PATCH spice-g
t;, spice-de...@freedesktop.org
> > Sent: Monday, April 28, 2014 11:54:03 AM
> > Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless
> device ref/unref
> >
> > On Mon, Apr 28, 2014 at 6:48 PM, Jonathon Jongsma >wrote:
> >
> > >
- Original Message -
> From: "Marc-André Lureau"
> To: "Jonathon Jongsma"
> Cc: "Uri Lublin" , "Marc-André Lureau" ,
> spice-de...@freedesktop.org
> Sent: Monday, April 28, 2014 11:54:03 AM
> Subject: Re: [Spice-devel] [PATC
:49:59 AM
> > Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless
> device ref/unref
> >
> >
> > On Mon, Apr 28, 2014 at 4:42 PM, Uri Lublin < u...@redhat.com > wrote:
> >
> >
> >
> > On 04/28/2014 03:49 PM, Marc-André L
- Original Message -
> From: "Marc-André Lureau"
> To: "Uri Lublin"
> Cc: "Marc-André Lureau" , spice-de...@freedesktop.org
> Sent: Monday, April 28, 2014 9:49:59 AM
> Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless
On Mon, Apr 28, 2014 at 4:42 PM, Uri Lublin wrote:
> On 04/28/2014 03:49 PM, Marc-André Lureau wrote:
>
>>
>> - Original Message -
>>
>>> On 04/23/2014 09:09 PM, Marc-André Lureau wrote:
>>>
A code doing an unref() on an object just before manipulating it looks
horribly suspicio
On 04/28/2014 03:49 PM, Marc-André Lureau wrote:
- Original Message -
On 04/23/2014 09:09 PM, Marc-André Lureau wrote:
A code doing an unref() on an object just before manipulating it looks
horribly suspicious...
Suspicious indeed.
But probably it's better to move the unref below ins
- Original Message -
> On 04/23/2014 09:09 PM, Marc-André Lureau wrote:
> > A code doing an unref() on an object just before manipulating it looks
> > horribly suspicious...
>
> Suspicious indeed.
>
> But probably it's better to move the unref below instead of removing the
> ref/unref (
On 04/23/2014 09:09 PM, Marc-André Lureau wrote:
A code doing an unref() on an object just before manipulating it looks
horribly suspicious...
Suspicious indeed.
But probably it's better to move the unref below instead of removing the
ref/unref (see below).
A device is ref'ed when install/u
On Wed, Apr 23, 2014 at 11:15 PM, Jonathon Jongsma wrote:
> Hm, I agree that the existing code does look very suspicious, but in
> general I think that ensuring that a ref is held for the duration of the
> async operation is probably a good idea. From a very cursory investigation
> it looks like
be safe in this scenario either...
- Original Message -
> From: "Marc-André Lureau"
> To: spice-de...@freedesktop.org
> Sent: Wednesday, April 23, 2014 1:09:13 PM
> Subject: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device
> ref/unref
>
A code doing an unref() on an object just before manipulating it looks
horribly suspicious...
---
gtk/usb-device-manager.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index a505c19..af993aa 100644
--- a/gtk/usb-devi
13 matches
Mail list logo
