Re: [Spice-devel] [PATCH spice-gtk 08/10] gtk: use GHashTable in display_cache

2013-09-10 Thread Marc-André Lureau
On Mon, Sep 9, 2013 at 9:19 PM, Yonit Halperin wrote: > Hi, > > In general it looks good, but I have several comments: > > (1) the palette cache shouldn't be shared among the display channels. I.e., > there should be one instance per channel, and not one instance in > spice-session. Ok, I thought

Re: [Spice-devel] [PATCH spice-gtk 08/10] gtk: use GHashTable in display_cache

2013-09-09 Thread Yonit Halperin
Hi, In general it looks good, but I have several comments: (1) the palette cache shouldn't be shared among the display channels. I.e., there should be one instance per channel, and not one instance in spice-session. (2) I think you changed the ref_count logic of cache item. Now each cache val

[Spice-devel] [PATCH spice-gtk 08/10] gtk: use GHashTable in display_cache

2013-09-08 Thread Marc-André Lureau
From: Marc-André Lureau The cache code isn't very quick, it shows up in profilers. Using GHashTable allows to simplify the code while making it faster. --- gtk/channel-cursor.c | 56 +++ gtk/channel-display.c | 93 +++--- gtk/spice-