Re: [Spice-devel] [PATCH spice-gtk 06/15] webdav: move initialization to session

2014-11-26 Thread Marc-André Lureau
- Original Message - > On Wed, 2014-11-26 at 13:58 +0100, Marc-André Lureau wrote: > > Hi > > > > On Tue, Nov 25, 2014 at 11:49 PM, Jonathon Jongsma > > wrote: > > > I find this name a little inconsistent. Generally the first part of the > > > function name indicates the type of object

Re: [Spice-devel] [PATCH spice-gtk 06/15] webdav: move initialization to session

2014-11-26 Thread Jonathon Jongsma
On Wed, 2014-11-26 at 13:58 +0100, Marc-André Lureau wrote: > Hi > > On Tue, Nov 25, 2014 at 11:49 PM, Jonathon Jongsma > wrote: > > I find this name a little inconsistent. Generally the first part of the > > function name indicates the type of object that this method belongs to. > > Except con

Re: [Spice-devel] [PATCH spice-gtk 06/15] webdav: move initialization to session

2014-11-26 Thread Marc-André Lureau
Hi On Tue, Nov 25, 2014 at 11:49 PM, Jonathon Jongsma wrote: > I find this name a little inconsistent. Generally the first part of the > function name indicates the type of object that this method belongs to. Except constructors, like here. > So I'd expect channel_webdav_server_new() to take a

Re: [Spice-devel] [PATCH spice-gtk 06/15] webdav: move initialization to session

2014-11-25 Thread Jonathon Jongsma
On Tue, 2014-11-25 at 14:19 +0100, Marc-André Lureau wrote: > Use session accessors to initialize the webdav server > --- > gtk/channel-webdav.c | 24 +--- > gtk/spice-session-priv.h | 2 ++ > gtk/spice-session.c | 23 +++ > 3 files changed, 30 ins

[Spice-devel] [PATCH spice-gtk 06/15] webdav: move initialization to session

2014-11-25 Thread Marc-André Lureau
Use session accessors to initialize the webdav server --- gtk/channel-webdav.c | 24 +--- gtk/spice-session-priv.h | 2 ++ gtk/spice-session.c | 23 +++ 3 files changed, 30 insertions(+), 19 deletions(-) diff --git a/gtk/channel-webdav.c b/gtk/cha