Re: [Spice-devel] [PATCH spice-gtk 0/5] RFC: Improve handling of large clipboard data

2013-11-07 Thread Marc-André Lureau
I'll hold it for now, since we are still discussing the protocol message. On Thu, Nov 7, 2013 at 11:42 PM, Jonathon Jongsma wrote: > Other than the minor issues I pointed out separately, the rest of this > looks OK to me. > > On Wed, 2013-11-06 at 22:25 +0100, Marc-André Lureau wrote: >> From: Ma

Re: [Spice-devel] [PATCH spice-gtk 0/5] RFC: Improve handling of large clipboard data

2013-11-07 Thread Jonathon Jongsma
Other than the minor issues I pointed out separately, the rest of this looks OK to me. On Wed, 2013-11-06 at 22:25 +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > Hi, > > It's quite easy to crash a spice-gtk client when a clipboard operation > take large data buffers. There are s

[Spice-devel] [PATCH spice-gtk 0/5] RFC: Improve handling of large clipboard data

2013-11-06 Thread Marc-André Lureau
From: Marc-André Lureau Hi, It's quite easy to crash a spice-gtk client when a clipboard operation take large data buffers. There are several ways this can go wrong (2 ways client side, 2 ways guest side), from what I have found, gdk & glib are mostly safe (at least on win32 backend, after gbo 7