Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

2016-06-20 Thread Fabiano Fidêncio
On Mon, Jun 20, 2016 at 5:34 PM, Marc-André Lureau wrote: > Hi > > On Mon, Jun 20, 2016 at 5:33 PM, Marc-André Lureau > wrote: >> On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio >> wrote: gtk_widget_set_can_focus(widget, true); +gtk_event_box_set_above_child(GTK_EVENT_BOX(w

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

2016-06-20 Thread Marc-André Lureau
Hi On Mon, Jun 20, 2016 at 5:33 PM, Marc-André Lureau wrote: > On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio > wrote: >>> gtk_widget_set_can_focus(widget, true); >>> +gtk_event_box_set_above_child(GTK_EVENT_BOX(widget), true); >> >> I'd just do: s/true/TRUE before pushing, but no n

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

2016-06-20 Thread Marc-André Lureau
On Mon, Jun 20, 2016 at 5:28 PM, Fabiano Fidêncio wrote: >> gtk_widget_set_can_focus(widget, true); >> +gtk_event_box_set_above_child(GTK_EVENT_BOX(widget), true); > > I'd just do: s/true/TRUE before pushing, but no need to resend the > patch because of this is just my preference :-) The

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

2016-06-20 Thread Fabiano Fidêncio
On Mon, Jun 20, 2016 at 3:22 PM, wrote: > From: Marc-André Lureau > > Since the switch to a container widget (gtkstack then gtkeventbox), the > grab may be lost when clicking on the display. Since events are treated > at the top level container, set widget "above-child" to trap all of them > to

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

2016-06-20 Thread Marc-André Lureau
Hi - Original Message - > > > From: Marc-André Lureau > > > > Since the switch to a container widget (gtkstack then gtkeventbox), the > > grab may be lost when clicking on the display. Since events are treated > > at the top level container, set widget "above-child" to trap all of them

Re: [Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

2016-06-20 Thread Frediano Ziglio
> From: Marc-André Lureau > > Since the switch to a container widget (gtkstack then gtkeventbox), the > grab may be lost when clicking on the display. Since events are treated > at the top level container, set widget "above-child" to trap all of them > to solve this. > > Fixes: > https://bugs.f

[Spice-devel] [PATCH spice-gtk] widget: fix keyboard ungrab after click

2016-06-20 Thread marcandre . lureau
From: Marc-André Lureau Since the switch to a container widget (gtkstack then gtkeventbox), the grab may be lost when clicking on the display. Since events are treated at the top level container, set widget "above-child" to trap all of them to solve this. Fixes: https://bugs.freedesktop.org/show