Re: [Spice-devel] [PATCH spice-gtk] gtk-session: Set value directly

2017-02-20 Thread Victor Toso
Hi, On Fri, Feb 17, 2017 at 01:44:55PM +0100, Pavel Grunt wrote: > Spotted by coverity Including the coverity message instead would be more interesting IMHO. Acked-by: Victor Toso > --- > src/spice-gtk-session.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src

Re: [Spice-devel] [PATCH spice-gtk] gtk-session: Set value directly

2017-02-19 Thread Uri Lublin
On 02/17/2017 06:17 PM, Pavel Grunt wrote: On Fri, 2017-02-17 at 10:01 -0600, Jonathon Jongsma wrote: On Fri, 2017-02-17 at 13:44 +0100, Pavel Grunt wrote: Spotted by coverity Acked-by: Jonathon Jongsma out of curiosity, what did coverity actually say here? spice-gtk-0.33.53-7cb7-dirty/s

Re: [Spice-devel] [PATCH spice-gtk] gtk-session: Set value directly

2017-02-17 Thread Pavel Grunt
On Fri, 2017-02-17 at 10:01 -0600, Jonathon Jongsma wrote: > On Fri, 2017-02-17 at 13:44 +0100, Pavel Grunt wrote: > > Spotted by coverity > > Acked-by: Jonathon Jongsma > > out of curiosity, what did coverity actually say here? > spice-gtk-0.33.53-7cb7-dirty/src/spice-gtk-session.c:920:9: not

Re: [Spice-devel] [PATCH spice-gtk] gtk-session: Set value directly

2017-02-17 Thread Jonathon Jongsma
On Fri, 2017-02-17 at 13:44 +0100, Pavel Grunt wrote: > Spotted by coverity Acked-by: Jonathon Jongsma out of curiosity, what did coverity actually say here? > --- >  src/spice-gtk-session.c | 6 ++ >  1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/spice-gtk-session.c

[Spice-devel] [PATCH spice-gtk] gtk-session: Set value directly

2017-02-17 Thread Pavel Grunt
Spotted by coverity --- src/spice-gtk-session.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index a3a2e90..5688cba 100644 --- a/src/spice-gtk-session.c +++ b/src/spice-gtk-session.c @@ -916,25 +916,23 @@ static gboolea