Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Marc-André Lureau
Hi On Wed, Sep 19, 2018 at 7:06 PM Victor Toso wrote: > > Hi, > > On Wed, Sep 19, 2018 at 05:51:13PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Sep 19, 2018 at 3:26 PM Victor Toso wrote: > > > > > > Hi, > > > > > > Tested the qmp part, so far, so good. Some comments/suggestions > > >

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Victor Toso
Hi, On Wed, Sep 19, 2018 at 05:51:13PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Sep 19, 2018 at 3:26 PM Victor Toso wrote: > > > > Hi, > > > > Tested the qmp part, so far, so good. Some comments/suggestions > > bellow. > > > > On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@re

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Marc-André Lureau
Hi On Wed, Sep 19, 2018 at 3:26 PM Victor Toso wrote: > > Hi, > > Tested the qmp part, so far, so good. Some comments/suggestions > bellow. > > On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Add a few helper functions to deal with

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-09-19 Thread Victor Toso
Hi, Tested the qmp part, so far, so good. Some comments/suggestions bellow. On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a few helper functions to deal with a QMP port channel, in order > to ease json handling, and wrapping a few

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-08-29 Thread Marc-André Lureau
Hi On Fri, Aug 10, 2018 at 3:45 PM wrote: > > From: Marc-André Lureau > > Add a few helper functions to deal with a QMP port channel, in order > to ease json handling, and wrapping a few commands. > > (by convention, the port should have the name > "org.qemu.monitor.qmp.0", but it's not strictly

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-08-13 Thread Marc-André Lureau
Hi On Fri, Aug 10, 2018 at 11:26 PM, Victor Toso wrote: > Hi, > > On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Add a few helper functions to deal with a QMP port channel, in order >> to ease json handling, and wrapping a few comman

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-08-10 Thread Victor Toso
Hi, On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a few helper functions to deal with a QMP port channel, in order > to ease json handling, and wrapping a few commands. > > (by convention, the port should have the name > "org.qemu

[Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-08-10 Thread marcandre . lureau
From: Marc-André Lureau Add a few helper functions to deal with a QMP port channel, in order to ease json handling, and wrapping a few commands. (by convention, the port should have the name "org.qemu.monitor.qmp.0", but it's not strictly required) This helper is put into use in the virt-viewer