Re: [Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

2012-05-18 Thread Marc-André Lureau
- Mensaje original - > From the same book ("not sure it is a good idea"), I'm > not really sure we should add yet another configurable > setting... How about passing the key event through if > it is a modifier key, and not if it is a regular key? ack, that should be simple I'll prepare

Re: [Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

2012-05-18 Thread Hans de Goede
Hi, On 05/18/2012 02:15 PM, Marc-André Lureau wrote: Hi Agreed, for modifiers, but what if the key binding is changed to shift+F12 as rhev does? Then I'm not sure sending the key events to the guest is desirable ... what if we make this configurable, and default to non-passthrough? that will

Re: [Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

2012-05-18 Thread Marc-André Lureau
Hi > Agreed, for modifiers, but what if the key binding > is changed to shift+F12 as rhev does? Then I'm not sure > sending the key events to the guest is desirable ... what if we make this configurable, and default to non-passthrough? that will be up to the application to change the behaviour de

Re: [Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

2012-05-18 Thread Hans de Goede
Hi, On 05/18/2012 01:21 PM, Marc-André Lureau wrote: - Mensaje original - Hi, On 05/17/2012 11:42 PM, Marc-André Lureau wrote: The remote may want to use that same key sequence, so we better send it through, even if it matches the ungrab key combination. I'm not sure about this, i

Re: [Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

2012-05-18 Thread Marc-André Lureau
- Mensaje original - > Hi, > > On 05/17/2012 11:42 PM, Marc-André Lureau wrote: > > The remote may want to use that same key sequence, > > so we better send it through, even if it matches > > the ungrab key combination. > > I'm not sure about this, if the grab-sequence is > getting in t

Re: [Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

2012-05-17 Thread Hans de Goede
Hi, On 05/17/2012 11:42 PM, Marc-André Lureau wrote: The remote may want to use that same key sequence, so we better send it through, even if it matches the ungrab key combination. I'm not sure about this, if the grab-sequence is getting in the way, maybe we need a different grab-sequence? Wh

[Spice-devel] [PATCH spice-gtk] do not eat ungrab key-sequence

2012-05-17 Thread Marc-André Lureau
The remote may want to use that same key sequence, so we better send it through, even if it matches the ungrab key combination. --- gtk/spice-widget.c |2 -- 1 file changed, 2 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index e6c252d..fad9db5 100644 --- a/gtk/spice-widge