Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-26 Thread Marc-André Lureau
Hi Jeremy, patch sent a few hours ago http://lists.freedesktop.org/archives/spice-devel/2013-November/015595.html cheers - Original Message - > On 11/19/2013 03:23 PM, Marc-André Lureau wrote: > > Make the coroutine code more glib-like, by aborting on OOM or unhandled > > conditions. >

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-26 Thread Jeremy White
On 11/19/2013 03:23 PM, Marc-André Lureau wrote: Make the coroutine code more glib-like, by aborting on OOM or unhandled conditions. According to my git bisect tests, this patch is causing a lovely crash for me: *** longjmp causes uninitialized stack frame ***: /home/jwhite/xfer/spice/bin/s

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-20 Thread Christophe Fergeau
On Tue, Nov 19, 2013 at 10:23:00PM +0100, Marc-André Lureau wrote: > Make the coroutine code more glib-like, by aborting on OOM or unhandled > conditions. Once again, 'glib-like' is vague enough that it does not mean much, glib is not aborting on all system errors. Let's just say for coroutines we

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-20 Thread Christophe Fergeau
On Tue, Nov 19, 2013 at 10:23:00PM +0100, Marc-André Lureau wrote: > diff --git a/spice-common b/spice-common > index 1450bb4..261d270 16 > --- a/spice-common > +++ b/spice-common > @@ -1 +1 @@ > -Subproject commit 1450bb4ddbd8ceab9192e4f84606aa5ae54c5ea6 > +Subproject commit 261d270cc8e9af0915

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-20 Thread Christophe Fergeau
On Tue, Nov 19, 2013 at 10:23:00PM +0100, Marc-André Lureau wrote: > @@ -76,20 +74,13 @@ int coroutine_init(struct coroutine *co) > MAP_PRIVATE | MAP_ANONYMOUS, > -1, 0); > if (co->cc.stack == MAP_FAILED) > - g_error("Failed to a

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-20 Thread Marc-André Lureau
On Tue, Nov 19, 2013 at 10:23 PM, Marc-André Lureau wrote: > Make the coroutine code more glib-like, by aborting on OOM or unhandled > conditions. > --- > gtk/continuation.c| 9 - > gtk/continuation.h| 2 +- > gtk/coroutine.h | 3 ++- > gtk/coroutine_gthread.c

[Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-19 Thread Marc-André Lureau
Make the coroutine code more glib-like, by aborting on OOM or unhandled conditions. --- gtk/continuation.c| 9 - gtk/continuation.h| 2 +- gtk/coroutine.h | 3 ++- gtk/coroutine_gthread.c | 12 ++-- gtk/coroutine_ucontext.c | 17 - gt

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-19 Thread Marc-André Lureau
ok - Original Message - > On Tue, Nov 19, 2013 at 05:30:55PM +0100, Marc-André Lureau wrote: > > @@ -75,21 +73,13 @@ int coroutine_init(struct coroutine *co) > > PROT_READ | PROT_WRITE, > > MAP_PRIVATE | MAP_ANONYMOUS, > >

Re: [Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-19 Thread Christophe Fergeau
On Tue, Nov 19, 2013 at 05:30:55PM +0100, Marc-André Lureau wrote: > @@ -75,21 +73,13 @@ int coroutine_init(struct coroutine *co) > PROT_READ | PROT_WRITE, > MAP_PRIVATE | MAP_ANONYMOUS, > -1, 0); > - if (co->cc.stack

[Spice-devel] [PATCH spice-gtk] coroutine: abort on OOM or impossible conditions

2013-11-19 Thread Marc-André Lureau
Make the coroutine code more glib-like, by aborting on OOM or unhandled conditions. --- gtk/continuation.c| 8 +++- gtk/continuation.h| 2 +- gtk/coroutine.h | 3 ++- gtk/coroutine_gthread.c | 7 ++- gtk/coroutine_ucontext.c | 18 -- gtk/cor