Re: [Spice-devel] [PATCH spice-gtk] channel: clear channel error after auth error

2014-12-16 Thread Marc-André Lureau
On Tue, Dec 16, 2014 at 6:36 PM, Pavel Grunt wrote: > ACK this and the series Thanks a lot Pavel for finding the regression and your help! -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.or

Re: [Spice-devel] [PATCH spice-gtk] channel: clear channel error after auth error

2014-12-16 Thread Pavel Grunt
> > This patch depends on "Fix authentication error handling regression" > series. > ACK this and the series Pavel ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk] channel: clear channel error after auth error

2014-12-16 Thread Marc-André Lureau
This patch depends on "Fix authentication error handling regression" series. On Tue, Dec 16, 2014 at 6:33 PM, Marc-André Lureau wrote: > When entered authentication details are wrong, spice-gtk will reset > channel error, which will result in the following warning: > > (remote-viewer:20753): GLib

[Spice-devel] [PATCH spice-gtk] channel: clear channel error after auth error

2014-12-16 Thread Marc-André Lureau
When entered authentication details are wrong, spice-gtk will reset channel error, which will result in the following warning: (remote-viewer:20753): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's code. You must ensure an er