Re: [Spice-devel] [PATCH spice-gtk] Use "#pragma once" instead of preprocessor guards

2019-08-11 Thread Frediano Ziglio
> > > Oh, just noticed, if this pushed, we may want to change the spice > style doc as well > > Snir. > Nice idea. Maybe add this style for new file. Would also be nice to update also spice-common and spice-server. > On 8/11/19 12:01 PM, Snir Sheriber wrote: > > Hi, > > > > It could be an iss

Re: [Spice-devel] [PATCH spice-gtk] Use "#pragma once" instead of preprocessor guards

2019-08-11 Thread Snir Sheriber
Oh, just noticed, if this pushed, we may want to change the spice style doc as well Snir. On 8/11/19 12:01 PM, Snir Sheriber wrote: Hi, It could be an issue with duplicated name headers but seems we do not have such headers. Ack On 7/29/19 5:23 PM, Frediano Ziglio wrote: Guards currently a

Re: [Spice-devel] [PATCH spice-gtk] Use "#pragma once" instead of preprocessor guards

2019-08-11 Thread Snir Sheriber
Hi, It could be an issue with duplicated name headers but seems we do not have such headers. Ack On 7/29/19 5:23 PM, Frediano Ziglio wrote: Guards currently are quite different in format. Unify updating to "#pragma once" syntax. This syntax is used by GTK tools too. To avoid possible regressio

Re: [Spice-devel] [PATCH spice-gtk] Use "#pragma once" instead of preprocessor guards

2019-08-09 Thread Frediano Ziglio
ping > > Guards currently are quite different in format. > Unify updating to "#pragma once" syntax. This syntax is used > by GTK tools too. > To avoid possible regression public headers are left untouched. > > Signed-off-by: Frediano Ziglio > --- > src/bio-gio.h | 5 +

[Spice-devel] [PATCH spice-gtk] Use "#pragma once" instead of preprocessor guards

2019-07-29 Thread Frediano Ziglio
Guards currently are quite different in format. Unify updating to "#pragma once" syntax. This syntax is used by GTK tools too. To avoid possible regression public headers are left untouched. Signed-off-by: Frediano Ziglio --- src/bio-gio.h | 5 + src/channel-display-pri