On Fri, 2017-06-09 at 11:33 +0200, Christophe de Dinechin wrote:
> >
> > On 8 Jun 2017, at 23:17, Jonathon Jongsma
> > wrote:
> >
> > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
> > unnecessary since g_log() will already check whether the message
> > will
> > actually be print
> > On 9 Jun 2017, at 17:47, Frediano Ziglio < fzig...@redhat.com > wrote:
>
> > > On Fri, 2017-06-09 at 05:47 -0400, Frediano Ziglio wrote:
> >
>
> > > > > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
> > > >
> > >
> >
>
> > > > > unnecessary since g_log() will already c
> On 9 Jun 2017, at 17:47, Frediano Ziglio wrote:
>
>>
>> On Fri, 2017-06-09 at 05:47 -0400, Frediano Ziglio wrote:
Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
unnecessary since g_log() will already check whether the message
will
actually be printed.
>
> On Fri, 2017-06-09 at 05:47 -0400, Frediano Ziglio wrote:
> > >
> > > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
> > > unnecessary since g_log() will already check whether the message
> > > will
> > > actually be printed. The only benefit to calling this function from
> >
On Fri, 2017-06-09 at 05:47 -0400, Frediano Ziglio wrote:
> >
> > Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
> > unnecessary since g_log() will already check whether the message
> > will
> > actually be printed. The only benefit to calling this function from
> > SPICE_DEBUG() i
>
> Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
> unnecessary since g_log() will already check whether the message will
> actually be printed. The only benefit to calling this function from
> SPICE_DEBUG() is that it ensures that the SPICE_DEBUG environment
> variable gets read
>
> On 8 Jun 2017, at 23:17, Jonathon Jongsma wrote:
>
> Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
> unnecessary since g_log() will already check whether the message will
> actually be printed. The only benefit to calling this function from
> SPICE_DEBUG() is that it ensures
Calling spice_util_get_debug() from the SPICE_DEBUG() macro is
unnecessary since g_log() will already check whether the message will
actually be printed. The only benefit to calling this function from
SPICE_DEBUG() is that it ensures that the SPICE_DEBUG environment
variable gets read the very firs
