Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-23 Thread Hans de Goede
Hi, On 04/22/2012 03:16 PM, Marc-André Lureau wrote: Hi On Sun, Apr 22, 2012 at 9:40 AM, Alon Levy wrote: On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote: So it seems like we should keep sending repeat key press in fact. And it's probably better to rely on client-side repea

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-23 Thread Hans de Goede
Hi, On 04/20/2012 01:59 AM, Marc-André Lureau wrote: Hi Now that I implemented it a bit more correctly, using a timer, and splitting the in two patches, I realize that it doesn't work with windows. Windows expect to receive several key press events apparently. Hmm, that would mean that window

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-22 Thread Alon Levy
On Sun, Apr 22, 2012 at 03:16:20PM +0200, Marc-André Lureau wrote: > Hi > > On Sun, Apr 22, 2012 at 9:40 AM, Alon Levy wrote: > > On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote: > >> So it seems like we should keep sending repeat key press in fact. And > >> it's probably better

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-22 Thread Marc-André Lureau
Hi On Sun, Apr 22, 2012 at 9:40 AM, Alon Levy wrote: > On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote: >> So it seems like we should keep sending repeat key press in fact. And >> it's probably better to rely on client-side repeat, since letting the >> server handling it may lea

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-22 Thread Alon Levy
On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote: > Hi > > Now that I implemented it a bit more correctly, using a timer, and > splitting the in two patches, I realize that it doesn't work with > windows. Windows expect to receive several key press events > apparently. Hans, the h

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-19 Thread Marc-André Lureau
Hi Now that I implemented it a bit more correctly, using a timer, and splitting the in two patches, I realize that it doesn't work with windows. Windows expect to receive several key press events apparently. Hans, the hack you mentionned in spicec doesn't seem to be what you said, since spicec cli

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-19 Thread Hans de Goede
Hi, On 04/19/2012 03:17 AM, Marc-André Lureau wrote: The remote end receives key press and key release seperately, but this can cause extra key repetition between the two event messages: - if the network is slow - if the server is busy and doesn't handle the events quickly enough - if the client

Re: [Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-18 Thread Alon Levy
On Thu, Apr 19, 2012 at 03:17:15AM +0200, Marc-André Lureau wrote: > The remote end receives key press and key release seperately, but this > can cause extra key repetition between the two event messages: > - if the network is slow > - if the server is busy and doesn't handle the events quickly eno

[Spice-devel] [PATCH spice-gtk] RFC: widget: improve undesired key repeatition

2012-04-18 Thread Marc-André Lureau
The remote end receives key press and key release seperately, but this can cause extra key repetition between the two event messages: - if the network is slow - if the server is busy and doesn't handle the events quickly enough - if the client is slow or busy (I think the guest/os couldn't be resp