Re: [Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

2016-07-28 Thread Snir Sheriber
Tested with valgrind, looks good. On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau While reviewing lz4 patch, I found that there are potential leaks. This is untested, fyi. It would be nice if someone could confirm with running ASAN for example. Signed-off-b

Re: [Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

2016-07-27 Thread Marc-André Lureau
hi - Original Message - > Hi, > > > On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > While reviewing lz4 patch, I found that there are potential leaks. This > > is untested, fyi. It would be nice if someone could confirm with running > > ASA

Re: [Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

2016-07-27 Thread Snir Sheriber
Hi, On 07/11/2016 06:16 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau While reviewing lz4 patch, I found that there are potential leaks. This is untested, fyi. It would be nice if someone could confirm with running ASAN for example. Thanks for reviewing this:) I've made some

Re: [Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

2016-07-12 Thread Victor Toso
Hi, On Mon, Jul 11, 2016 at 05:16:25PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > While reviewing lz4 patch, I found that there are potential leaks. This > is untested, fyi. It would be nice if someone could confirm with running > ASAN for example. > Yes, thanks. Thi

[Spice-devel] [PATCH spice-gtk] RFC: usbredir: fix leaks introduced by lz4 patch

2016-07-11 Thread marcandre . lureau
From: Marc-André Lureau While reviewing lz4 patch, I found that there are potential leaks. This is untested, fyi. It would be nice if someone could confirm with running ASAN for example. Signed-off-by: Marc-André Lureau --- src/channel-usbredir.c | 8 +--- 1 file changed, 5 insertions(+),