Re: [Spice-devel] [PATCH spice-gtk] If replace me, should not do refcount plus one

2018-07-18 Thread yueyi...@os-easy.com
: yueyihua CC: Christophe Fergeau; spice-devel Subject: Re: [Spice-devel] [PATCH spice-gtk] If replace me, should not do refcount plus one OK, I have modified it. From 87be8732bf36038c9ba9faabb1aae58f7b830d05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=B9=90=E4=B9=89=E5=8D=8E?= Date: Thu, 12

Re: [Spice-devel] [PATCH spice-gtk] If replace me, should not do refcount plus one

2018-07-18 Thread Frediano Ziglio
; + display_cache_item *item = cache_item_new(id, lossy); > > > + > > > + g_hash_table_replace(cache->table, item, value); > > > +} > > > + > > > static inline void cache_add(display_cache *cache, uint64_t id, gpointer > > value) &g

Re: [Spice-devel] [PATCH spice-gtk] If replace me, should not do refcount plus one

2018-07-17 Thread yueyi...@os-easy.com
evel; 乐义华 Subject: Re: [Spice-devel] [PATCH spice-gtk] If replace me, should not do refcount plus one On Tue, Jul 17, 2018 at 08:17:53AM +0100, Frediano Ziglio wrote: > From: 乐义华 > > When an image with SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME is received the > reference counter should stay

Re: [Spice-devel] [PATCH spice-gtk] If replace me, should not do refcount plus one

2018-07-17 Thread Christophe Fergeau
On Tue, Jul 17, 2018 at 08:17:53AM +0100, Frediano Ziglio wrote: > From: 乐义华 > > When an image with SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME is received the > reference counter should stay the same to avoid the cache to grow > continously. > > This fixes https://gitlab.freedesktop.org/spice/spice-gtk/

[Spice-devel] [PATCH spice-gtk] If replace me, should not do refcount plus one

2018-07-17 Thread Frediano Ziglio
From: 乐义华 When an image with SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME is received the reference counter should stay the same to avoid the cache to grow continously. This fixes https://gitlab.freedesktop.org/spice/spice-gtk/issues/72 Signed-off-by: 乐义华 Signed-off-by: Frediano Ziglio --- src/channel