Re: [Spice-devel] [PATCH spice-gtk] Fix crash when closing while recording

2012-04-06 Thread Alon Levy
On Fri, Apr 06, 2012 at 04:08:17AM +0200, Marc-André Lureau wrote: > First notify about disconnection before resetting the channel data. > An audio recording task might expect the channel to be in a ready > state otherwise, for example. > I'm wondering if this is enough - what if the event emitte

Re: [Spice-devel] [PATCH spice-gtk] Fix crash when closing while recording

2012-04-06 Thread Hans de Goede
ACk. On 04/06/2012 04:08 AM, Marc-André Lureau wrote: First notify about disconnection before resetting the channel data. An audio recording task might expect the channel to be in a ready state otherwise, for example. https://bugzilla.redhat.com/show_bug.cgi?id=810247 --- gtk/spice-channel.c

[Spice-devel] [PATCH spice-gtk] Fix crash when closing while recording

2012-04-05 Thread Marc-André Lureau
First notify about disconnection before resetting the channel data. An audio recording task might expect the channel to be in a ready state otherwise, for example. https://bugzilla.redhat.com/show_bug.cgi?id=810247 --- gtk/spice-channel.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions