On Wed, Jan 30, 2013 at 10:24 AM, Christophe Fergeau
wrote:
> Yes, exactly, this seems like the behaviour users of this API would expect,
ok, pushed
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.free
On Tue, Jan 29, 2013 at 06:23:15PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jan 29, 2013 at 6:09 PM, Christophe Fergeau
> wrote:
> > On Tue, Jan 29, 2013 at 06:01:34PM +0100, Marc-André Lureau wrote:
> >> On Tue, Jan 29, 2013 at 5:54 PM, Christophe Fergeau
> >> wrote:
> >> > update_pro
Hi
On Tue, Jan 29, 2013 at 6:09 PM, Christophe Fergeau wrote:
> On Tue, Jan 29, 2013 at 06:01:34PM +0100, Marc-André Lureau wrote:
>> On Tue, Jan 29, 2013 at 5:54 PM, Christophe Fergeau
>> wrote:
>> > update_proxy(session, NULL); will never unset an already set proxy.
>>
>>
>> If SPICE_PROXY is
On Tue, Jan 29, 2013 at 06:01:34PM +0100, Marc-André Lureau wrote:
> On Tue, Jan 29, 2013 at 5:54 PM, Christophe Fergeau
> wrote:
> > update_proxy(session, NULL); will never unset an already set proxy.
>
>
> If SPICE_PROXY is set, it will replace it if it's a valid value.
>
> If SPICE_PROXY is
On Tue, Jan 29, 2013 at 5:54 PM, Christophe Fergeau wrote:
> update_proxy(session, NULL); will never unset an already set proxy.
If SPICE_PROXY is set, it will replace it if it's a valid value.
If SPICE_PROXY is not set, it won't replace it, keep current proxy. Is
that a problem?
--
Marc-And
On Tue, Jan 29, 2013 at 05:45:00PM +0100, Marc-André Lureau wrote:
> On Tue, Jan 29, 2013 at 5:10 PM, Christophe Fergeau
> wrote:
> > The patch seems to have been pushed without addressing this comment?
>
> Ah sorry, I missed the comments. There is already a
> g_clear_object(&s->proxy); or I don
On Tue, Jan 29, 2013 at 5:10 PM, Christophe Fergeau wrote:
> The patch seems to have been pushed without addressing this comment?
Ah sorry, I missed the comments. There is already a
g_clear_object(&s->proxy); or I don't get what you mean.
--
Marc-André Lureau
On Tue, Jan 29, 2013 at 02:12:57PM +0100, Christophe Fergeau wrote:
> On Tue, Jan 29, 2013 at 01:33:43PM +0100, Marc-André Lureau wrote:
> > @@ -118,24 +119,29 @@ enum {
> > static guint signals[SPICE_SESSION_LAST_SIGNAL];
> >
> >
> > -static SpiceProxy* get_proxy(void)
> > +static void update
On Tue, Jan 29, 2013 at 01:33:43PM +0100, Marc-André Lureau wrote:
> Add a session property to set proxy setting, since it is racy to rely
> on setenv(). Also doing so would override system environment, which
> will modify other session too sharing the same process.
>
> v2:
> - keep old proxy if u
Add a session property to set proxy setting, since it is racy to rely
on setenv(). Also doing so would override system environment, which
will modify other session too sharing the same process.
v2:
- keep old proxy if update_proxy() fails
- remove strlen() usage
- return NULL in spice_proxy_to_str
10 matches
Mail list logo
