Re: [Spice-devel] [PATCH spice-gtk] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-19 Thread Jonathon Jongsma
If you want to keep it, I won't object. just noting that it isn't strictly necessary. - Original Message - > From: "Marc-André Lureau" > To: "Jonathon Jongsma" > Cc: "Marc-André Lureau" , > spice-devel@lists.freedesktop.org, "Marc-André Lureau" > > Sent: Tuesday, November 19, 2013

Re: [Spice-devel] [PATCH spice-gtk] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-19 Thread Marc-André Lureau
I just wanted to have environment value in ->max_clipboard too, to make it more obvious when debugging (if printing *self for example) Furthermore, since the environment value can be adjusted dynamically now, it could as well be removed. And I think it's better to keep the SPICE_MAX_CLIPBOARD v

Re: [Spice-devel] [PATCH spice-gtk] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-19 Thread Jonathon Jongsma
I don't think you need the 'constructed' vfunc at all anymore. You're accessing the max clipboard value exclusively through the getter now, so it doesn't really matter whether priv->max_clipboard gets overwritten with the environment value at construction or not. Otherwise ACK. - Original

Re: [Spice-devel] [PATCH spice-gtk] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-19 Thread Marc-André Lureau
(To be applied after 1/5 from http://lists.freedesktop.org/archives/spice-devel/2013-November/015257.html) On Tue, Nov 19, 2013 at 5:50 PM, Marc-André Lureau wrote: > Allow to easily override default max-clipboard value with environment > variable. > --- > gtk/channel-main.c | 33 +++

[Spice-devel] [PATCH spice-gtk] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-19 Thread Marc-André Lureau
Allow to easily override default max-clipboard value with environment variable. --- gtk/channel-main.c | 33 - 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index d4b4416..2c02ece 100644 --- a/gtk/channel-main