Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-10-04 Thread Lukáš Hrázký
On Thu, 2018-10-04 at 07:25 -0400, Frediano Ziglio wrote: > > On Tue, 2018-10-02 at 11:21 -0400, Frediano Ziglio wrote: > > > > On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote: > > > > > ping > > > > > > > > Sorry, I was thinking how to handle this and eventually forgot about > > > > it.

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-10-04 Thread Frediano Ziglio
> On Tue, 2018-10-02 at 11:21 -0400, Frediano Ziglio wrote: > > > On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote: > > > > ping > > > > > > Sorry, I was thinking how to handle this and eventually forgot about > > > it. Two notes: > > > > > > 1. Without really looking into the differences

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-10-02 Thread Lukáš Hrázký
On Tue, 2018-10-02 at 11:21 -0400, Frediano Ziglio wrote: > > On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote: > > > ping > > > > Sorry, I was thinking how to handle this and eventually forgot about > > it. Two notes: > > > > 1. Without really looking into the differences in the protocol

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-10-02 Thread Frediano Ziglio
> On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote: > > ping > > Sorry, I was thinking how to handle this and eventually forgot about > it. Two notes: > > 1. Without really looking into the differences in the protocol, I would > expect some part of the spice_codegen.py that was specific t

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-10-02 Thread Lukáš Hrázký
On Fri, 2018-09-28 at 03:41 -0400, Frediano Ziglio wrote: > ping Sorry, I was thinking how to handle this and eventually forgot about it. Two notes: 1. Without really looking into the differences in the protocol, I would expect some part of the spice_codegen.py that was specific to the old protoc

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-09-28 Thread Victor Toso
Hi, On Fri, Sep 28, 2018 at 03:41:29AM -0400, Frediano Ziglio wrote: > ping Sorry, I was pretty sure that I acked this because I did run some tests and found nothing wrong at time. Probably forgot to come back. Acked-by: Victor Toso > > SPICE version 2 was introduced more than 8 years ago. > >

Re: [Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-09-28 Thread Frediano Ziglio
ping > > SPICE version 2 was introduced more than 8 years ago. > RHEL 6 already removed support for version 1 in the server. > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 1 - > common/Makefile.am | 8 - > common/client_marshallers.h | 1 - > common/me

[Spice-devel] [PATCH spice-common v2] proto: Remove support for SPICE version 1

2018-09-21 Thread Frediano Ziglio
SPICE version 2 was introduced more than 8 years ago. RHEL 6 already removed support for version 1 in the server. Signed-off-by: Frediano Ziglio --- Makefile.am | 1 - common/Makefile.am | 8 - common/client_marshallers.h | 1 - common/meson.build | 2 -