Re: [Spice-devel] [PATCH spice-common 2/3] lz: Optimise SAME_PIXEL for RGB16

2018-05-24 Thread Jonathon Jongsma
On Thu, 2018-05-24 at 07:38 -0400, Frediano Ziglio wrote: > > > > On Thu, 2018-05-10 at 13:03 -0400, Frediano Ziglio wrote: > > > > > > > > On Wed, 2018-05-09 at 14:10 +0100, Frediano Ziglio wrote: > > > > > Do not extract all components and compare one by one, can be > > > > > easily > > > > > c

Re: [Spice-devel] [PATCH spice-common 2/3] lz: Optimise SAME_PIXEL for RGB16

2018-05-24 Thread Frediano Ziglio
> > On Thu, 2018-05-10 at 13:03 -0400, Frediano Ziglio wrote: > > > > > > On Wed, 2018-05-09 at 14:10 +0100, Frediano Ziglio wrote: > > > > Do not extract all components and compare one by one, can be > > > > easily > > > > compared together. > > > > > > Do you have some data about how performan

Re: [Spice-devel] [PATCH spice-common 2/3] lz: Optimise SAME_PIXEL for RGB16

2018-05-10 Thread Jonathon Jongsma
On Thu, 2018-05-10 at 13:03 -0400, Frediano Ziglio wrote: > > > > On Wed, 2018-05-09 at 14:10 +0100, Frediano Ziglio wrote: > > > Do not extract all components and compare one by one, can be > > > easily > > > compared together. > > > > Do you have some data about how performance compares between

Re: [Spice-devel] [PATCH spice-common 2/3] lz: Optimise SAME_PIXEL for RGB16

2018-05-10 Thread Frediano Ziglio
> > On Wed, 2018-05-09 at 14:10 +0100, Frediano Ziglio wrote: > > Do not extract all components and compare one by one, can be easily > > compared together. > > Do you have some data about how performance compares between the two > implementations? The new implementation clearly looks more effici

Re: [Spice-devel] [PATCH spice-common 2/3] lz: Optimise SAME_PIXEL for RGB16

2018-05-10 Thread Jonathon Jongsma
On Wed, 2018-05-09 at 14:10 +0100, Frediano Ziglio wrote: > Do not extract all components and compare one by one, can be easily > compared together. Do you have some data about how performance compares between the two implementations? The new implementation clearly looks more efficient, but the co

[Spice-devel] [PATCH spice-common 2/3] lz: Optimise SAME_PIXEL for RGB16

2018-05-09 Thread Frediano Ziglio
Do not extract all components and compare one by one, can be easily compared together. Signed-off-by: Frediano Ziglio --- common/lz_compress_tmpl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/lz_compress_tmpl.c b/common/lz_compress_tmpl.c index 69e69a6..b778e