Re: [Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: >> >> Frediano Ziglio writes: >> >> > Is just used by ring_remove, no reason to have it. >> >> Nack. I think there is a good reason: the code and its intent is much >> clearer with a "ring_remove" name. >> > > Don't get it... are you saying __ring_remove name is more clear

Re: [Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Frediano Ziglio
> > Frediano Ziglio writes: > > > Is just used by ring_remove, no reason to have it. > > Nack. I think there is a good reason: the code and its intent is much > clearer with a "ring_remove" name. > Don't get it... are you saying __ring_remove name is more clear than ring_remove ? > > > > > S

Re: [Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > Is just used by ring_remove, no reason to have it. Nack. I think there is a good reason: the code and its intent is much clearer with a "ring_remove" name. > > Signed-off-by: Frediano Ziglio > --- > common/ring.h | 11 +++ > 1 file changed, 3 insertions(+),

[Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Frediano Ziglio
Is just used by ring_remove, no reason to have it. Signed-off-by: Frediano Ziglio --- common/ring.h | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/common/ring.h b/common/ring.h index 4b0e313..036c098 100644 --- a/common/ring.h +++ b/common/ring.h @@ -70,19 +70,14