Re: [Spice-devel] [PATCH spice-common] region: Avoid possible memory corruption

2017-02-28 Thread Frediano Ziglio
> > Ack, > Pavel > > btw Has pixman some api documentation ? > I didn't find much, had to look at the sources. This function is not called much apparently (mainly in streaming code) but I'm quite surprised it didn't trigger something worst than a leak! Looks like Valgrind got too slow recently.

Re: [Spice-devel] [PATCH spice-common] region: Avoid possible memory corruption

2017-02-28 Thread Pavel Grunt
Ack, Pavel btw Has pixman some api documentation ? On Tue, 2017-02-28 at 14:53 +, Frediano Ziglio wrote: > pixman_region32_copy assume that destination (first argument) > is initialized and can use a pointer inside based on different > conditions. > As intersection is not initialized this can

[Spice-devel] [PATCH spice-common] region: Avoid possible memory corruption

2017-02-28 Thread Frediano Ziglio
pixman_region32_copy assume that destination (first argument) is initialized and can use a pointer inside based on different conditions. As intersection is not initialized this can cause different memory problems. This resulted in memory leak detection from address sanitizer. Signed-off-by: Fredia