Re: [Spice-devel] [PATCH spice-common] proto: Demarshal Smartcard data field

2019-10-08 Thread Victor Toso
Hi, On Mon, Oct 07, 2019 at 11:38:58AM +0100, Frediano Ziglio wrote: > Currently the demarshaler code is not used by spice-server. > Demarshal all the fields of the header message, not only the header. > Using generated code allows to easily check data and support > big endian machines. Generated

Re: [Spice-devel] [PATCH spice-common] proto: Demarshal Smartcard data field

2019-10-07 Thread Frediano Ziglio
> > Hi, > > On Mon, Oct 07, 2019 at 11:38:58AM +0100, Frediano Ziglio wrote: > > Currently the demarshaler code is not used by spice-server. > > Demarshal all the fields of the header message, not only the header. > > Using generated code allows to easily check data and support > > big endian mac

Re: [Spice-devel] [PATCH spice-common] proto: Demarshal Smartcard data field

2019-10-07 Thread Victor Toso
Hi, On Mon, Oct 07, 2019 at 11:38:58AM +0100, Frediano Ziglio wrote: > Currently the demarshaler code is not used by spice-server. > Demarshal all the fields of the header message, not only the header. > Using generated code allows to easily check data and support > big endian machines. Generated

[Spice-devel] [PATCH spice-common] proto: Demarshal Smartcard data field

2019-10-07 Thread Frediano Ziglio
Currently the demarshaler code is not used by spice-server. Demarshal all the fields of the header message, not only the header. Using generated code allows to easily check data and support big endian machines. Generated code will be used by spice-server. The resulting change is. diff -ru gen/