Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-30 Thread Christophe Fergeau
Hey, On Thu, Nov 29, 2018 at 12:23:16PM -0500, Frediano Ziglio wrote: > > For example, when Marc-André added the json-glib dependency ( > > https://lists.freedesktop.org/archives/spice-devel/2018-August/045202.html > > ), we did not get first a patch adding the new dep and not doing > > anythingel

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-29 Thread Christophe de Dinechin
> On 29 Nov 2018, at 18:23, Frediano Ziglio wrote: > >> Hey, >> >> On Thu, Nov 29, 2018 at 08:50:47AM -0500, Frediano Ziglio wrote: On Wed, Nov 28, 2018 at 11:23:17AM +0100, Christophe de Dinechin wrote: >> On 27 Nov 2018, at 15:38, Christophe Fergeau >> wrote: >> I'm n

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-29 Thread Frediano Ziglio
> Hey, > > On Thu, Nov 29, 2018 at 08:50:47AM -0500, Frediano Ziglio wrote: > > > > > > On Wed, Nov 28, 2018 at 11:23:17AM +0100, Christophe de Dinechin wrote: > > > > > On 27 Nov 2018, at 15:38, Christophe Fergeau > > > > > wrote: > > > > > I'm not really asking how to use it, but it's very odd

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-29 Thread Christophe Fergeau
Hey, On Thu, Nov 29, 2018 at 08:50:47AM -0500, Frediano Ziglio wrote: > > > > On Wed, Nov 28, 2018 at 11:23:17AM +0100, Christophe de Dinechin wrote: > > > > On 27 Nov 2018, at 15:38, Christophe Fergeau > > > > wrote: > > > > I'm not really asking how to use it, but it's very odd to have a patc

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-29 Thread Frediano Ziglio
> > On Wed, Nov 28, 2018 at 11:23:17AM +0100, Christophe de Dinechin wrote: > > > On 27 Nov 2018, at 15:38, Christophe Fergeau wrote: > > > I'm not really asking how to use it, but it's very odd to have a patch > > > adding a new dep without seeing any accompanying patches which need that > > > d

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-28 Thread Christophe Fergeau
On Wed, Nov 28, 2018 at 11:23:17AM +0100, Christophe de Dinechin wrote: > > On 27 Nov 2018, at 15:38, Christophe Fergeau wrote: > > I'm not really asking how to use it, but it's very odd to have a patch > > adding a new dep without seeing any accompanying patches which need that > > dependency. >

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-28 Thread Christophe de Dinechin
> On 27 Nov 2018, at 15:38, Christophe Fergeau wrote: > > On Thu, Nov 22, 2018 at 05:58:01AM -0500, Frediano Ziglio wrote: >>> >>> Hey, >>> >>> On Mon, Nov 19, 2018 at 08:46:04PM +, Frediano Ziglio wrote: From: Christophe de Dinechin Allow to use recorder library. See htt

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-27 Thread Christophe Fergeau
On Thu, Nov 22, 2018 at 05:58:01AM -0500, Frediano Ziglio wrote: > > > > Hey, > > > > On Mon, Nov 19, 2018 at 08:46:04PM +, Frediano Ziglio wrote: > > > From: Christophe de Dinechin > > > > > > Allow to use recorder library. See https://github.com/c3d/recorder for > > > details. > > > The m

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-22 Thread Frediano Ziglio
> > Hey, > > On Mon, Nov 19, 2018 at 08:46:04PM +, Frediano Ziglio wrote: > > From: Christophe de Dinechin > > > > Allow to use recorder library. See https://github.com/c3d/recorder for > > details. > > The main usage will be to collect statistics while the programs will run. > > By default

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-21 Thread Christophe Fergeau
Hey, On Mon, Nov 19, 2018 at 08:46:04PM +, Frediano Ziglio wrote: > From: Christophe de Dinechin > > Allow to use recorder library. See https://github.com/c3d/recorder for > details. > The main usage will be to collect statistics while the programs will run. > By default the recorder will be

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-20 Thread Christophe de Dinechin
> On 20 Nov 2018, at 13:49, Frediano Ziglio wrote: > >> >> Thanks Frediano, >> >> >> Reviewed-by: Christophe de Dinechin >> >> >>> On 19 Nov 2018, at 21:46, Frediano Ziglio wrote: >>> >>> From: Christophe de Dinechin >> >> Replace with “Suggested-by: “ :-) >> >> >>> >>> Allow to us

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-20 Thread Frediano Ziglio
> > Thanks Frediano, > > > Reviewed-by: Christophe de Dinechin > > > > On 19 Nov 2018, at 21:46, Frediano Ziglio wrote: > > > > From: Christophe de Dinechin > > Replace with “Suggested-by: “ :-) > > > > > > Allow to use recorder library. See https://github.com/c3d/recorder for > > deta

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-20 Thread Christophe de Dinechin
Thanks Frediano, Reviewed-by: Christophe de Dinechin > On 19 Nov 2018, at 21:46, Frediano Ziglio wrote: > > From: Christophe de Dinechin Replace with “Suggested-by: “ :-) > > Allow to use recorder library. See https://github.com/c3d/recorder for > details. > The main usage will be to co

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-19 Thread Frediano Ziglio
> > From: Christophe de Dinechin > Well... probably I started with some other patches and git kept the author. > Allow to use recorder library. See https://github.com/c3d/recorder for > details. > The main usage will be to collect statistics while the programs will run. > By default the record

[Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-19 Thread Frediano Ziglio
From: Christophe de Dinechin Allow to use recorder library. See https://github.com/c3d/recorder for details. The main usage will be to collect statistics while the programs will run. By default the recorder will be disabled at compile time. Both autoconf and Meson are supported. Autoconf requires