Re: [Spice-devel] [PATCH spice-common] Fix harmless warnings in quic_encode()

2012-03-28 Thread Alon Levy
On Wed, Mar 28, 2012 at 01:33:22PM +0200, Marc-André Lureau wrote: ACK. > The quic code has been changed recently this way: > > -ASSERT(encoder->usr, line); > +if (line == NULL) { > +spice_warn_if_reached(); > +return QUIC_ERROR; > +} > > It appears that the only cal

[Spice-devel] [PATCH spice-common] Fix harmless warnings in quic_encode()

2012-03-28 Thread Marc-André Lureau
The quic code has been changed recently this way: -ASSERT(encoder->usr, line); +if (line == NULL) { +spice_warn_if_reached(); +return QUIC_ERROR; +} It appears that the only caller of quic_encode() gives a NULL line and rely on the more_lines() callback to return new l