Re: [Spice-devel] [PATCH spice] update windows client generate.bat and generate1.bat

2012-04-17 Thread Aric Stewart
Ah, my apologies. I will admit I have a bit of a hybrid environment. I do almost all my development on my mac and have a windows box for testing/building. It must have been during my editing of the file in vi that it got the EOL characters changed. I will modify my git send formatting to not

Re: [Spice-devel] [PATCH spice] update windows client generate.bat and generate1.bat

2012-04-17 Thread Alon Levy
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote: > > the python script is now in spice-common and client_marshallers.h needs to > be included instead of marshallers.h Third, the patch doesn't apply because of EOL issues. You should be using no EOL convertion magic. If you use msysgit

Re: [Spice-devel] [PATCH spice] update windows client generate.bat and generate1.bat

2012-04-17 Thread Alon Levy
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote: > In the future could you send the patches inlined and not attached? I use git format-patch or git send-email directly. > the python script is now in spice-common and client_marshallers.h needs to > be included instead of marshallers.

Re: [Spice-devel] [PATCH spice] update windows client generate.bat and generate1.bat

2012-04-17 Thread Alon Levy
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote: > > the python script is now in spice-common and client_marshallers.h needs to > be included instead of marshallers.h Looks good, haven't tested but I'll assume you did :) ACK, and pushing. > --- > client/windows/generate.bat |

[Spice-devel] [PATCH spice] update windows client generate.bat and generate1.bat

2012-04-16 Thread Aric Stewart
the python script is now in spice-common and client_marshallers.h needs to be included instead of marshallers.h --- client/windows/generate.bat |4 ++-- client/windows/generate1.bat |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/client/windows/generate.bat b/