Re: [Spice-devel] [PATCH spice] update visual studio project file

2012-04-18 Thread Alon Levy
On Tue, Apr 17, 2012 at 06:24:18PM -0500, Aric Stewart wrote: > Note, there may be line-ending issues here is we are not careful. This file > is a msdos formatted file. > I've pushed all your fixes, including a commit to update the spice-common submodule to include your fixes (create_bitmap and

Re: [Spice-devel] [PATCH spice] update visual studio project file

2012-04-18 Thread Alon Levy
On Wed, Apr 18, 2012 at 07:30:19AM -0500, Aric Stewart wrote: > As a test I have found that I can convert the line-endings to linux style > and Visual Studio 2008 still handles the file without issue. Of course if I > or a future developer make project changes in VC and then save the project > it w

Re: [Spice-devel] [PATCH spice] update visual studio project file

2012-04-18 Thread Aric Stewart
As a test I have found that I can convert the line-endings to linux style and Visual Studio 2008 still handles the file without issue. Of course if I or a future developer make project changes in VC and then save the project it will by default covert the line endings back to MSDOS format. -ar

Re: [Spice-devel] [PATCH spice] update visual studio project file

2012-04-18 Thread Aric Stewart
I wonder if the process of having to include the patch as text into my e-mail is what is munging the line endings. I could check if VC can handle a project file with linux style line endings and then we could normalize to linux line endings and see if that helps... -aric On 4/18/12 6:17 AM,

Re: [Spice-devel] [PATCH spice] update visual studio project file

2012-04-18 Thread Alon Levy
On Tue, Apr 17, 2012 at 06:24:18PM -0500, Aric Stewart wrote: > Note, there may be line-ending issues here is we are not careful. This file > is a msdos formatted file. > > There was some inconsistencies in those line-ending that I have normalized. Aric, this doesn't apply at all, I get a gazi

[Spice-devel] [PATCH spice] update visual studio project file

2012-04-17 Thread Aric Stewart
Note, there may be line-ending issues here is we are not careful. This file is a msdos formatted file. There was some inconsistencies in those line-ending that I have normalized. Signed-off-by: Aric Stewart --- client/windows/redc.vcproj | 84 ++-- 1