Re: [Spice-devel] [PATCH linux vdagent 1/2] systemd: use "After" with "Requisite"

2018-11-01 Thread Uri Lublin
On 10/31/18 10:31 PM, Jonathon Jongsma wrote: So, I just discovered this year-old patch that (as far as I can tell) was never reviewed or pushed upstream. Is anybody willing to review it? I found it also here: https://www.freedesktop.org/software/systemd/man/systemd.unit.html Ack. Uri. Jon

Re: [Spice-devel] [PATCH linux vdagent 1/2] systemd: use "After" with "Requisite"

2018-11-01 Thread Lukáš Hrázký
Hello, On Wed, 2018-10-31 at 15:31 -0500, Jonathon Jongsma wrote: > So, I just discovered this year-old patch that (as far as I can tell) > was never reviewed or pushed upstream. Is anybody willing to review it? > > Jonathon > > > On Wed, 2017-11-29 at 10:44 -0600, Jonathon Jongsma wrote: > > T

Re: [Spice-devel] [PATCH linux vdagent 1/2] systemd: use "After" with "Requisite"

2018-10-31 Thread Jonathon Jongsma
So, I just discovered this year-old patch that (as far as I can tell) was never reviewed or pushed upstream. Is anybody willing to review it? Jonathon On Wed, 2017-11-29 at 10:44 -0600, Jonathon Jongsma wrote: > The "Requisite" directive is intended to require that the virtio port > device exist

[Spice-devel] [PATCH linux vdagent 1/2] systemd: use "After" with "Requisite"

2017-11-29 Thread Jonathon Jongsma
The "Requisite" directive is intended to require that the virtio port device exists before starting the vdagent socket unit. If the device does not exist, the socket should fail to start. However, without using "After", the socket will still start even when the device is not present. See https://g