On Mon, Dec 08, 2014 at 04:25:24PM +0100, Christophe Fergeau wrote:
> On Mon, Dec 08, 2014 at 03:37:32PM +0100, Marc-André Lureau wrote:
> > So much of this is quite irrelevant to the discussion at hand about
> > unreviewed commit rule.
>
> I know this is about a lot of stuff, libvirt HACKING fine
goes to 2 lists for post-review, and I would prefer people stick to
technical conversations rather than community guidelines when there is
no need for it and it doesn't noticeably improve the project for the
rest of the people outside this very tiny contributor community.
Now this is a place whe
On Mon, Dec 8, 2014 at 4:54 PM, Christophe Fergeau wrote:
> Well, in this case, most people in this thread agreed the patch was not
> trivial. Since you felt differently about it and thought it was eligible
> to being pushed without review, I think these rules should give some
> guidelines in the
On Mon, Dec 08, 2014 at 04:34:18PM +0100, Marc-André Lureau wrote:
> On Mon, Dec 8, 2014 at 4:25 PM, Christophe Fergeau
> wrote:
> > « **if a recently committed patch** breaks compilation on a platform or
> > for a given driver, then it's fine to commit a **minimal** fix directly
> > without gett
On Mon, Dec 8, 2014 at 4:25 PM, Christophe Fergeau wrote:
> « **if a recently committed patch** breaks compilation on a platform or
> for a given driver, then it's fine to commit a **minimal** fix directly
> without getting the review feedback first »
What is minimal? The resulting file is a doze
On Mon, Dec 08, 2014 at 03:37:32PM +0100, Marc-André Lureau wrote:
> So much of this is quite irrelevant to the discussion at hand about
> unreviewed commit rule.
I know this is about a lot of stuff, libvirt HACKING fine had plenty of
interesting things, so I thought why not keep them. I don't min
So much of this is quite irrelevant to the discussion at hand about
unreviewed commit rule.
We already have a cooding style:
http://www.spice-space.org/docs/spice_style.pdf although as always,
it's arguable and we haven't been following too strictly (thankfully)
In general I don't think we need t
This is libvirt's HACKING file with some parts not relevant to SPICE
removed. It contains some git advice, some C coding style rules, and
an attempt at defining what a trivial patch is.
---
Hey,
After the latest thread about trivial patches, I realized that libvirt actually
has a definition of wha
