Re: [Spice-devel] [PATCH 6/7] Respect IOV_MAX if defined

2012-02-17 Thread Alon Levy
On Fri, Feb 17, 2012 at 01:08:42PM +0100, Paolo Bonzini wrote: > On 02/17/2012 10:08 AM, Alon Levy wrote: > > Isn't this another candidate for ifdeferry? > > It actually applies to Linux too, except that IOV_MAX is 1024. > > See in fs/read_write.c > > 709 static ssize_t do_readv_writev(int type,

Re: [Spice-devel] [PATCH 6/7] Respect IOV_MAX if defined

2012-02-17 Thread Paolo Bonzini
On 02/17/2012 10:08 AM, Alon Levy wrote: > Isn't this another candidate for ifdeferry? It actually applies to Linux too, except that IOV_MAX is 1024. See in fs/read_write.c 709 static ssize_t do_readv_writev(int type, struct file *file, 710const struct iovec __use

Re: [Spice-devel] [PATCH 6/7] Respect IOV_MAX if defined

2012-02-17 Thread Alon Levy
On Thu, Feb 16, 2012 at 11:30:12PM -0600, Dan McGee wrote: > Solaris has a pitiful maximum writev vector size of only 16, so the ping > request at initial startup destroyed this call and broke things > immediately. Reimplement stream_writev_cb() to respect IOV_MAX and break > the writev() calls int

[Spice-devel] [PATCH 6/7] Respect IOV_MAX if defined

2012-02-16 Thread Dan McGee
Solaris has a pitiful maximum writev vector size of only 16, so the ping request at initial startup destroyed this call and broke things immediately. Reimplement stream_writev_cb() to respect IOV_MAX and break the writev() calls into chunks as necessary. Care was taken to return the correct values