Re: [Spice-devel] [PATCH 4/5] client: improve WAN option description

2011-07-19 Thread Christophe Fergeau
On Tue, Jul 19, 2011 at 02:48:16PM +0300, Alon Levy wrote: > On Tue, Jul 19, 2011 at 01:42:54PM +0200, Christophe Fergeau wrote: > > Sorry, I was too hasty pushing it. Should I make an additional commit to > > split it? > > Not Important. Too late :) How does the patch below look? Christophe F

Re: [Spice-devel] [PATCH 4/5] client: improve WAN option description

2011-07-19 Thread Alon Levy
On Tue, Jul 19, 2011 at 01:42:54PM +0200, Christophe Fergeau wrote: > On Tue, Jul 19, 2011 at 02:34:35PM +0300, Alon Levy wrote: > > > > Can you split the line at the same time? I guess this break is another > > reason to have a limit > > to line length. > > Sorry, I was too hasty pushing it. Sh

Re: [Spice-devel] [PATCH 4/5] client: improve WAN option description

2011-07-19 Thread Christophe Fergeau
On Tue, Jul 19, 2011 at 02:34:35PM +0300, Alon Levy wrote: > > Can you split the line at the same time? I guess this break is another reason > to have a limit > to line length. Sorry, I was too hasty pushing it. Should I make an additional commit to split it? Christophe pgpuNLo5mELpl.pgp Desc

Re: [Spice-devel] [PATCH 4/5] client: improve WAN option description

2011-07-19 Thread Alon Levy
On Tue, Jul 19, 2011 at 01:22:13PM +0200, Christophe Fergeau wrote: > On Fri, Jul 08, 2011 at 12:17:31PM +0200, Christophe Fergeau wrote: > > diff --git a/client/application.cpp b/client/application.cpp > > index 8e9fd8a..18101a5 100644 > > --- a/client/application.cpp > > +++ b/client/application.

Re: [Spice-devel] [PATCH 4/5] client: improve WAN option description

2011-07-19 Thread Christophe Fergeau
On Fri, Jul 08, 2011 at 12:17:31PM +0200, Christophe Fergeau wrote: > diff --git a/client/application.cpp b/client/application.cpp > index 8e9fd8a..18101a5 100644 > --- a/client/application.cpp > +++ b/client/application.cpp > @@ -2276,11 +2276,11 @@ bool Application::process_cmd_line(int argc, cha

Re: [Spice-devel] [PATCH 4/5] client: improve WAN option description

2011-07-18 Thread Alon Levy
On Fri, Jul 08, 2011 at 12:17:31PM +0200, Christophe Fergeau wrote: > The WAN options (--color-depth and --disable-effects) need > support from the guest agent to be working. Currently they are > only supported on Windows. While I don't want to explicitly > mention Windows in --help output, we can

[Spice-devel] [PATCH 4/5] client: improve WAN option description

2011-07-08 Thread Christophe Fergeau
The WAN options (--color-depth and --disable-effects) need support from the guest agent to be working. Currently they are only supported on Windows. While I don't want to explicitly mention Windows in --help output, we can hint that it won't work with all guests in --help. This fixes RH bug #712941