Re: [Spice-devel] [PATCH 3.10/12] Remove a couple single-use static functions

2015-10-30 Thread Christophe Fergeau
On Fri, Oct 30, 2015 at 03:44:05AM -0400, Frediano Ziglio wrote: > OT: I don't fully agree with the reasoning. Today compilers are really > good inlining single used static functions. Putting even some lines in > small functions can improve readability if function name is well choosed, > future mai

Re: [Spice-devel] [PATCH 3.10/12] Remove a couple single-use static functions

2015-10-30 Thread Frediano Ziglio
> > From: Marc-André Lureau > > red_cursor_marshall_inval(), red_migrate_cursor() and > on_new_cursor_channel() were short functions that were each only called > from a single location, so there's no need for them to be separate > functions. > > Signed-off-by: Jonathon Jongsma Acked OT: I d

[Spice-devel] [PATCH 3.10/12] Remove a couple single-use static functions

2015-10-29 Thread Jonathon Jongsma
From: Marc-André Lureau red_cursor_marshall_inval(), red_migrate_cursor() and on_new_cursor_channel() were short functions that were each only called from a single location, so there's no need for them to be separate functions. Signed-off-by: Jonathon Jongsma --- server/cursor-channel.c | 9 +