Re: [Spice-devel] [PATCH 3/4] sound: Remove dead code in client constructors

2017-04-24 Thread Jonathon Jongsma
On Fri, 2017-04-21 at 05:10 -0400, Frediano Ziglio wrote: > > > > When a new PlaybackChannelClient or RecordChannelClient is created, > > there are several places where we make decisions based on whether > > the > > client is active or not. But these checks are done before the > > 'active' > > fla

Re: [Spice-devel] [PATCH 3/4] sound: Remove dead code in client constructors

2017-04-24 Thread Jonathon Jongsma
On Fri, 2017-04-21 at 05:10 -0400, Frediano Ziglio wrote: > > > > When a new PlaybackChannelClient or RecordChannelClient is created, > > there are several places where we make decisions based on whether > > the > > client is active or not. But these checks are done before the > > 'active' > > fla

Re: [Spice-devel] [PATCH 3/4] sound: Remove dead code in client constructors

2017-04-21 Thread Frediano Ziglio
> > When a new PlaybackChannelClient or RecordChannelClient is created, > there are several places where we make decisions based on whether the > client is active or not. But these checks are done before the 'active' > flag is ever set, so this code is effectively dead. This has been the > case si

[Spice-devel] [PATCH 3/4] sound: Remove dead code in client constructors

2017-04-20 Thread Jonathon Jongsma
When a new PlaybackChannelClient or RecordChannelClient is created, there are several places where we make decisions based on whether the client is active or not. But these checks are done before the 'active' flag is ever set, so this code is effectively dead. This has been the case since the very