Re: [Spice-devel] [PATCH 3/3] Don't abort if encoder cannot be created

2015-11-18 Thread Jonathon Jongsma
On Wed, 2015-11-18 at 09:57 -0500, Frediano Ziglio wrote: > > > > Hi, > > > > On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote: > > > Instead of using spice_critical() when an encoder cannot be created, use > > > a warning so that the server doesn't abort. > > > > I haven't seen an abor

Re: [Spice-devel] [PATCH 3/3] Don't abort if encoder cannot be created

2015-11-18 Thread Frediano Ziglio
> > Hi, > > On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote: > > Instead of using spice_critical() when an encoder cannot be created, use > > a warning so that the server doesn't abort. > > I haven't seen an abort because of it, and I think abort is correct, > otherwise > you may end u

Re: [Spice-devel] [PATCH 3/3] Don't abort if encoder cannot be created

2015-11-18 Thread Pavel Grunt
Hi, On Tue, 2015-11-17 at 16:38 -0600, Jonathon Jongsma wrote: > Instead of using spice_critical() when an encoder cannot be created, use > a warning so that the server doesn't abort. I haven't seen an abort because of it, and I think abort is correct, otherwise you may end up calling encode func

[Spice-devel] [PATCH 3/3] Don't abort if encoder cannot be created

2015-11-17 Thread Jonathon Jongsma
Instead of using spice_critical() when an encoder cannot be created, use a warning so that the server doesn't abort. --- server/dcc-encoders.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index 35edd41..